[tests] precommit tests for D156845

[arsenm]

llvm/test/Transforms/FunctionSpecialization/and-add-shl.ll

2 ↗

(On Diff #546360)

Seems like a strange move? I'd expect a new patch to only add a test to the relevant pass, not delete one from another

[Allen]

revert the change of deleting one from another

[Allen]

llvm/test/Transforms/FunctionSpecialization/and-add-shl.ll

2 ↗

(On Diff #546360)

Apply your comment, thanks

[Allen]

1、 replace the test file under llvm/test/Transforms/SCCP
2、 Add a new negative case and_not_shl_overlap

[StephenFan]

llvm/test/Transforms/SCCP/and-add-shl.ll

2

Can we replace ipsccp with sccp? These tests don't touch IPO, right?

[Allen]

llvm/test/Transforms/SCCP/and-add-shl.ll

2

I find they have some different result because we can propagate the value of llvm.ssa.copy.i8 when we enable the IPO.

+++ b/llvm/test/Transforms/SCCP/and-add-shl.ll
@@ -10,9 +10,10 @@ define i8 @and_add_shl(i8 %x) {
 ; CHECK-SAME: (i8 [[X:%.*]]) {
 ; CHECK-NEXT:    [[OP1_P2:%.*]] = icmp ule i8 [[X]], 5
 ; CHECK-NEXT:    call void @llvm.assume(i1 [[OP1_P2]])
-; CHECK-NEXT:    [[SHIFT:%.*]] = shl nuw nsw i8 1, [[X]]
-; CHECK-NEXT:    [[SUB:%.*]] = add nsw i8 [[SHIFT]], -1
-; CHECK-NEXT:    ret i8 0
+; CHECK-NEXT:    [[SHIFT:%.*]] = shl nuw i8 1, [[X]]
+; CHECK-NEXT:    [[SUB:%.*]] = add i8 [[SHIFT]], -1
+; CHECK-NEXT:    [[R:%.*]] = and i8 [[SUB]], 32
+; CHECK-NEXT:    ret i8 [[R]]
 ;
   %op1_p2 = icmp ule i8 %x, 5
   call void @llvm.assume(i1 %op1_p2)
@@ -65,8 +66,8 @@ define i8 @and_add_shl_overlap(i8 %x) {
 ; CHECK-SAME: (i8 [[X:%.*]]) {
 ; CHECK-NEXT:    [[OP1_P2:%.*]] = icmp ule i8 [[X]], 6
 ; CHECK-NEXT:    call void @llvm.assume(i1 [[OP1_P2]])
-; CHECK-NEXT:    [[SHIFT:%.*]] = shl nuw nsw i8 1, [[X]]
-; CHECK-NEXT:    [[SUB:%.*]] = add nsw i8 [[SHIFT]], -1
+; CHECK-NEXT:    [[SHIFT:%.*]] = shl nuw i8 1, [[X]]
+; CHECK-NEXT:    [[SUB:%.*]] = add i8 [[SHIFT]], -1
 ; CHECK-NEXT:    [[R:%.*]] = and i8 [[SUB]], 32

llvm/test/Transforms/SCCP/and-add-shl.ll

+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
+; RUN: opt < %s -passes=ipsccp -S | FileCheck %s
+
+declare void @llvm.assume(i1)
+declare i8 @llvm.ctpop.i8(i8)
+
+; https://alive2.llvm.org/ce/z/LV_8xy
+define i8 @and_add_shl(i8 %x) {
+; CHECK-LABEL: define i8 @and_add_shl
+; CHECK-SAME: (i8 [[X:%.*]]) {
+; CHECK-NEXT:    [[OP1_P2:%.*]] = icmp ule i8 [[X]], 5
+; CHECK-NEXT:    call void @llvm.assume(i1 [[OP1_P2]])
+; CHECK-NEXT:    [[SHIFT:%.*]] = shl nuw nsw i8 1, [[X]]
+; CHECK-NEXT:    [[SUB:%.*]] = add nsw i8 [[SHIFT]], -1
+; CHECK-NEXT:    ret i8 0
+;
+  %op1_p2 = icmp ule i8 %x, 5
+  call void @llvm.assume(i1 %op1_p2)
+  %shift = shl i8 1, %x
+  %sub = add i8 %shift, -1
+  %r = and i8 %sub, 32
+  ret i8 %r
+}
+
+; https://alive2.llvm.org/ce/z/YNYYdV
+define i8 @and_not_shl(i8 %x) {
+; CHECK-LABEL: define i8 @and_not_shl
+; CHECK-SAME: (i8 [[X:%.*]]) {
+; CHECK-NEXT:    [[OP1_P2:%.*]] = icmp ule i8 [[X]], 5
+; CHECK-NEXT:    call void @llvm.assume(i1 [[OP1_P2]])
+; CHECK-NEXT:    [[SHIFT:%.*]] = shl nsw i8 -1, [[X]]
+; CHECK-NEXT:    [[NOT:%.*]] = xor i8 [[SHIFT]], -1
+; CHECK-NEXT:    [[R:%.*]] = and i8 [[NOT]], 32
+; CHECK-NEXT:    ret i8 [[R]]
+;
+  %op1_p2 = icmp ule i8 %x, 5
+  call void @llvm.assume(i1 %op1_p2)
+  %shift = shl i8 -1, %x
+  %not = xor i8 %shift, -1
+  %r = and i8 %not, 32
+  ret i8 %r
+}
+
+define i8 @and_not_shl_1(i8 %x) {
+; CHECK-LABEL: define i8 @and_not_shl_1
+; CHECK-SAME: (i8 [[X:%.*]]) {
+; CHECK-NEXT:    [[OP1_P2:%.*]] = icmp ule i8 [[X]], 4
+; CHECK-NEXT:    call void @llvm.assume(i1 [[OP1_P2]])
+; CHECK-NEXT:    [[SHIFT:%.*]] = shl nsw i8 -1, [[X]]
+; CHECK-NEXT:    [[NOT:%.*]] = xor i8 [[SHIFT]], -1
+; CHECK-NEXT:    [[R:%.*]] = and i8 [[NOT]], 48
+; CHECK-NEXT:    ret i8 [[R]]
+;
+  %op1_p2 = icmp ule i8 %x, 4
+  call void @llvm.assume(i1 %op1_p2)
+  %shift = shl i8 -1, %x
+  %not = xor i8 %shift, -1
+  %r = and i8 %not, 48 ;    3 * 16
+  ret i8 %r
+}
+
+; Negative test: https://alive2.llvm.org/ce/z/Zv4Pyu
+define i8 @and_add_shl_overlap(i8 %x) {
+; CHECK-LABEL: define i8 @and_add_shl_overlap
+; CHECK-SAME: (i8 [[X:%.*]]) {
+; CHECK-NEXT:    [[OP1_P2:%.*]] = icmp ule i8 [[X]], 6
+; CHECK-NEXT:    call void @llvm.assume(i1 [[OP1_P2]])
+; CHECK-NEXT:    [[SHIFT:%.*]] = shl nuw nsw i8 1, [[X]]
+; CHECK-NEXT:    [[SUB:%.*]] = add nsw i8 [[SHIFT]], -1
+; CHECK-NEXT:    [[R:%.*]] = and i8 [[SUB]], 32
+; CHECK-NEXT:    ret i8 [[R]]
+;
+  %op1_p2 = icmp ule i8 %x, 6
+  call void @llvm.assume(i1 %op1_p2)
+  %shift = shl i8 1, %x
+  %sub = add i8 %shift, -1
+  %r = and i8 %sub, 32  ; expect 64
+  ret i8 %r
+}
+
+define i8 @and_not_shl_overlap(i8 %x) {
+; CHECK-LABEL: define i8 @and_not_shl_overlap
+; CHECK-SAME: (i8 [[X:%.*]]) {
+; CHECK-NEXT:    [[OP1_P2:%.*]] = icmp ule i8 [[X]], 3
+; CHECK-NEXT:    call void @llvm.assume(i1 [[OP1_P2]])
+; CHECK-NEXT:    [[SHIFT:%.*]] = shl nsw i8 -1, [[X]]
+; CHECK-NEXT:    [[NOT:%.*]] = xor i8 [[SHIFT]], -1
+; CHECK-NEXT:    [[R:%.*]] = and i8 [[NOT]], 4
+; CHECK-NEXT:    ret i8 [[R]]
+;
+  %op1_p2 = icmp ule i8 %x, 3
+  call void @llvm.assume(i1 %op1_p2)
+  %shift = shl i8 -1, %x
+  %not = xor i8 %shift, -1
+  %r = and i8 %not, 4   ; expect 8
+  ret i8 %r
+}