This is an archive of the discontinued LLVM Phabricator instance.

Generalize finding the rocm_agent_enumberator program
ClosedPublic

Authored by trixirt on Aug 1 2023, 2:09 PM.

Details

Summary

On Fedora, rocminfo is a fedora package and rocm_agent_enumberator is
installed to /usr/bin. This causes this error when building.

CMake Error at external/llvm-project/mlir/lib/ExecutionEngine/CMakeLists.txt:232 (message):

Could not run rocm_agent_enumerator and ROCM_TEST_CHIPSET is not defined

So use find_program() to look for rocm_agent_enumerator instead of assuming a
single location.

Signed-off-by: Tom Rix <trix@redhat.com>

Diff Detail

Event Timeline

trixirt created this revision.Aug 1 2023, 2:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2023, 2:09 PM
trixirt requested review of this revision.Aug 1 2023, 2:09 PM
krzysz00 accepted this revision.Aug 2 2023, 7:04 AM

Do you need me to land this?

This revision is now accepted and ready to land.Aug 2 2023, 7:04 AM

yes, i will need help landing this, i do not have commit permissions.

This revision was automatically updated to reflect the committed changes.