Page MenuHomePhabricator

trixirt (Tom Rix)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2015, 12:38 PM (300 w, 3 d)

Recent Activity

Dec 16 2020

trixirt added a comment to D93182: [clang-tidy] Add linux kernel log functions checker.

Yes, this change has problems, I will resubmit.
There are many log function checks in checkpatch, and i need to write another one to find the unattibuted decls.
I don't think adding linux specific warnings is -Wformat is needed, that doesn't scale with all the other projects wanting special attention
There may be a lot of checks and fixits added to linuxkernel/ . checkpatch only checks for new problems.

Dec 16 2020, 1:01 PM · Restricted Project, Restricted Project

Dec 13 2020

trixirt requested review of D93182: [clang-tidy] Add linux kernel log functions checker.
Dec 13 2020, 11:00 AM · Restricted Project, Restricted Project

Dec 3 2020

trixirt added a comment to D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros.

How this is run in the kernel is a wip so adding it to the commit log is not very helpful.
Here is the lkml rfc
https://lkml.org/lkml/2020/11/21/190
This calling in the kernel needs needs to change because of the refactor.

Dec 3 2020, 8:56 AM · Restricted Project, Restricted Project
trixirt updated the diff for D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros.

move enum

Dec 3 2020, 8:47 AM · Restricted Project, Restricted Project

Dec 2 2020

trixirt updated the diff for D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros.

address precheckin issues

Dec 2 2020, 7:24 AM · Restricted Project, Restricted Project

Nov 29 2020

trixirt updated the diff for D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros.

Refactor to combine switch and trailing macro into one fixer

Nov 29 2020, 8:40 AM · Restricted Project, Restricted Project

Nov 25 2020

trixirt updated the diff for D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros.

Addresses issues before refactoring.

Nov 25 2020, 6:32 AM · Restricted Project, Restricted Project

Nov 19 2020

trixirt requested review of D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros.
Nov 19 2020, 5:38 AM · Restricted Project, Restricted Project

Oct 31 2020

trixirt added a comment to D90180: [clang-tidy] find/fix unneeded semicolon after switch.

I am trying to address problems treewide so around 100 changes per fix.
Doing that requires consensus that the fix is generally ok for every subsystem in the code base.
So while clang will fix
switch () {} ;
it will also fix
for () {

// tbd : add something here
;

}
consensus needs to be found on as narrow a fix as possible.
so there will be a specialized fixer for each problem consensus is reached on.

Oct 31 2020, 5:59 AM · Restricted Project, Restricted Project

Oct 27 2020

trixirt added a comment to D90180: [clang-tidy] find/fix unneeded semicolon after switch.

Discussion of change on LKML
https://lkml.org/lkml/2020/10/27/2538

Oct 27 2020, 11:23 AM · Restricted Project, Restricted Project
trixirt updated the diff for D90180: [clang-tidy] find/fix unneeded semicolon after switch.

fix precheckin lint issues with auto vs const auto

Oct 27 2020, 11:11 AM · Restricted Project, Restricted Project
trixirt added a comment to D90180: [clang-tidy] find/fix unneeded semicolon after switch.

The 10,000 problems are for all the extra semicolon problems.
Those after switch are a small subset, chosen because is ok to automagically fix them.

Oct 27 2020, 6:12 AM · Restricted Project, Restricted Project
trixirt updated the diff for D90180: [clang-tidy] find/fix unneeded semicolon after switch.

precheckin lint fixes

Oct 27 2020, 5:46 AM · Restricted Project, Restricted Project

Oct 26 2020

trixirt added a comment to D90180: [clang-tidy] find/fix unneeded semicolon after switch.

Yes, this automates the fixit to something precise.
There are about 10,000 problems in the kernel with -Wextra-semi, all of those fixes would be too many and diverse to practically submit.
Also the -Wextra-semi fix removes just the semi and so it's fix will fail the kernel formatting check for an empty line.

Oct 26 2020, 5:01 PM · Restricted Project, Restricted Project
trixirt updated the diff for D90180: [clang-tidy] find/fix unneeded semicolon after switch.

Comment on the matcher
Comment explaining need to look for empty macro
Add test for normal switch
Add test for switch with empty macro
Fix formatting

Oct 26 2020, 4:49 PM · Restricted Project, Restricted Project
trixirt requested review of D90180: [clang-tidy] find/fix unneeded semicolon after switch.
Oct 26 2020, 11:28 AM · Restricted Project, Restricted Project

Oct 3 2020

trixirt requested review of D88784: Improve ccc-analyzer error message.
Oct 3 2020, 9:41 AM · Restricted Project

Aug 31 2020

trixirt added a comment to D83984: Explicitly use utf-8 in send_string.

Yes, this break on py2, and py3 the change is a noop

Aug 31 2020, 11:52 AM · Restricted Project

Jul 16 2020

trixirt created D83984: Explicitly use utf-8 in send_string.
Jul 16 2020, 1:42 PM · Restricted Project

Feb 6 2020

trixirt created D74184: Test std::equal with type qualified pointers.
Feb 6 2020, 5:09 PM · Restricted Project

May 21 2019

trixirt updated the diff for D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.

Add a newline to separate functions

May 21 2019, 8:02 PM · Restricted Project, Restricted Project
trixirt added inline comments to D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.
May 21 2019, 8:02 PM · Restricted Project, Restricted Project

May 20 2019

trixirt added a comment to D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.

Latest change addresses most of issues.
Outstanding is adding a test when garbage GuardStyle value is fed into config.
The trial testcase used only CHECK-*-NOT which caused complaining from test harness looking for the CHECK- cases.
Looking for something similar in the other checker tests did not turn up anything.
In general it seems like clang-tidy assumes developers get the string names of the options and their values correct and does not provide a lot of (any?) checking.

May 20 2019, 5:45 PM · Restricted Project, Restricted Project
trixirt updated the diff for D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.

Change the GuardStyle data type from a string to an enum.
Add test cases for explicitly setting valid style.
Document valid style values.
Reduce llvm-header-guard doc to point to bugprone-header-guard.

May 20 2019, 5:35 PM · Restricted Project, Restricted Project

May 13 2019

trixirt updated the diff for D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.

llvm-header-guard is an alias to bugprone-header-guard.
The style is passed through the option 'GuardStyle'

May 13 2019, 7:42 PM · Restricted Project, Restricted Project

May 6 2019

trixirt added a comment to D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.

All of the real work is the header-guard checks is done by their common base class utils/HeaderGuard.
The much smaller llvm and bugprone subclasses are only concerned with the style of the fix.

May 6 2019, 3:42 PM · Restricted Project, Restricted Project
trixirt updated the diff for D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.

Move from misc to bugprone

May 6 2019, 3:17 PM · Restricted Project, Restricted Project

May 4 2019

trixirt updated the diff for D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.

Addressed issue with returning early and using backtick in doc.
Since misc-header-guard doc was a cut-n-paste of llvm-header-guard, that and other similar docs were changed.

May 4 2019, 9:59 AM · Restricted Project, Restricted Project

May 3 2019

trixirt created D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.
May 3 2019, 7:34 AM · Restricted Project, Restricted Project

Apr 15 2019

trixirt added a comment to D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database.

A comment by whisperity in the origin WIP did not seem to be addressed.
Have you looked at IWYU https://github.com/include-what-you-use/include-what-you-use ?
The end goals of clang-scan-deps and iwyu seem similar so their implementation problems would also be similar.
The iwyu problems doc is https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/WhyIWYUIsDifficult.md

Apr 15 2019, 9:57 AM · Restricted Project, Restricted Project

Mar 29 2019

trixirt created D59998: [Sema] Remove unneeded call to LookupResult::resolveKind.
Mar 29 2019, 8:23 AM · Restricted Project

Nov 29 2018

trixirt added a comment to D53942: IR Outliner Pass.

Yvan,
I believe have a fix for the issue you found which can be found in my master-iro branch
https://github.com/trixirt/llvm/commit/873ce17e5fced2048b8c37b72cb5639041758226
Once it has made it through some more testing, I will merge it into this request.

Nov 29 2018, 9:30 AM · Restricted Project

Nov 21 2018

trixirt added a comment to D53942: IR Outliner Pass.

Yvan,
Thanks for giving this a try!
I do not have codemark pro, but tried the scenarios you mentioned out on the codemark.
No build problems, unfortunately.
If you can reproduce the problem, please send me the *.i
The MO/IRO refactoring i am doing may impact your thumb mo.
If you have a public dev branch for this, please send me the link.

Nov 21 2018, 1:54 PM · Restricted Project

Nov 16 2018

trixirt added a comment to D54047: Check TUScope is valid before use.

Since the crash happens with the iwyu tool, a bit ago i added the testcase at the iwyu project here.
https://github.com/include-what-you-use/include-what-you-use/pull/601

Nov 16 2018, 1:34 PM
trixirt updated the diff for D53942: IR Outliner Pass.

CodesizeOutliner has been changed to IROutliner
cli to enable has changed for *-cso to *-ir-outliner
Generated functions prefix changed for cso_ to _iro_
Some tests add.
Most issues in review fixed.
Exception is for significant refactoring, which was deferred to the larger task for refactoring MO/IRO to use MO infra.
A proof-of-concept of this refactor is https://github.com/trixirt/llvm/tree/master-poc-mo-refactor

Nov 16 2018, 1:07 PM · Restricted Project

Nov 2 2018

trixirt created D54047: Check TUScope is valid before use.
Nov 2 2018, 2:04 PM

Nov 1 2018

trixirt added a comment to D53942: IR Outliner Pass.

Thanks for the quick review!

Nov 1 2018, 5:33 PM · Restricted Project

Oct 31 2018

trixirt created D53942: IR Outliner Pass.
Oct 31 2018, 10:38 AM · Restricted Project

Aug 26 2018

trixirt added a comment to D51205: Move SuffixTree type to a common location.

Comments ?

Aug 26 2018, 7:42 PM

Aug 23 2018

trixirt created D51205: Move SuffixTree type to a common location.
Aug 23 2018, 8:37 PM

Aug 21 2018

trixirt added a comment to D50780: Check that the key is in the LEAs map before accessing.

I do not have commit perms, so can someone commit this for me ?

Aug 21 2018, 2:03 PM

Aug 20 2018

trixirt updated the diff for D50780: Check that the key is in the LEAs map before accessing.

Changes suggested by Craig.
For readability, move chooseBestLEA's variables closer to call.

Aug 20 2018, 1:31 PM
trixirt updated the diff for D50780: Check that the key is in the LEAs map before accessing.

Switch to using 'find' as suggested by Craig

Aug 20 2018, 7:11 AM

Aug 19 2018

trixirt added a comment to D50780: Check that the key is in the LEAs map before accessing.

I don't think there are any meaningful side effects.

Aug 19 2018, 9:02 AM
trixirt added a comment to D50780: Check that the key is in the LEAs map before accessing.

Any comments ?

Aug 19 2018, 7:57 AM

Aug 15 2018

trixirt created D50780: Check that the key is in the LEAs map before accessing.
Aug 15 2018, 7:09 AM

Jun 27 2018

trixirt added a comment to D47554: [analyzer] Check for dead/impossible status checks.

Sorry for the delay, i will have something (hopefully) this weekend.

Jun 27 2018, 6:35 AM

Jun 5 2018

trixirt updated the diff for D47554: [analyzer] Check for dead/impossible status checks.

cleanup of last patch

Jun 5 2018, 9:55 AM

Jun 4 2018

trixirt updated the diff for D47554: [analyzer] Check for dead/impossible status checks.

Convert to AST Visitor

Jun 4 2018, 4:08 PM

Jun 1 2018

trixirt added a comment to D47105: Fix compiler warning of extraneous parentheses.

This change fixes one of the few build warnings.
The extra parenthesis warning is noisy.
I agree there isn't an obvious best path.
I commented the code for this reason.

Jun 1 2018, 8:33 AM

May 30 2018

trixirt created D47554: [analyzer] Check for dead/impossible status checks.
May 30 2018, 1:16 PM

May 25 2018

Herald added a reviewer for D41881: [analyzer] Flag bcmp, bcopy and bzero as obsolete: george.karpenkov.

I need someone to commit this..

May 25 2018, 3:19 PM
trixirt added a comment to D47260: [DebugInfo] Skip MD5 checksums of preprocessed files.

commandeer away!
Sure that is fine.

May 25 2018, 1:11 PM · debug-info

May 24 2018

trixirt added a comment to D47327: Check that memory allocation succeeds before use..

I agree on the consensus building.

May 24 2018, 4:07 PM
trixirt added a comment to D47327: Check that memory allocation succeeds before use..

As llvm is mostly an api, i assumed that it would be robust and this was a one-off.
Anything big should be done automagically, so i am going to look at sic-ing clang-tidy and/or the static analyzer at this problem.

May 24 2018, 1:13 PM
trixirt updated the diff for D47327: Check that memory allocation succeeds before use..

use nothrow version of new

May 24 2018, 12:17 PM
trixirt added a comment to D47327: Check that memory allocation succeeds before use..

I will change this to try-catch

May 24 2018, 9:24 AM
trixirt created D47327: Check that memory allocation succeeds before use..
May 24 2018, 7:13 AM

May 23 2018

trixirt updated the diff for D47260: [DebugInfo] Skip MD5 checksums of preprocessed files.

Rename test to dwarf5-expansion-checksum.c

May 23 2018, 8:37 AM · debug-info
trixirt created D47260: [DebugInfo] Skip MD5 checksums of preprocessed files.
May 23 2018, 7:38 AM · debug-info

May 19 2018

trixirt updated the diff for D47105: Fix compiler warning of extraneous parentheses.

More content.

May 19 2018, 1:07 PM
trixirt created D47105: Fix compiler warning of extraneous parentheses.
May 19 2018, 8:25 AM

May 15 2018

trixirt updated the diff for D46791: Make -gsplit-dwarf generally available.

Improve comment in CLANG_DEFAULT_OBJCOPY to specify what is required of objcopy.
Remove the llvm- prefix from testing to allow for override of default value.

May 15 2018, 5:37 PM

May 11 2018

trixirt created D46791: Make -gsplit-dwarf generally available.
May 11 2018, 7:00 PM

May 10 2018

trixirt created D46719: Improve llc help message for -split-dwarf-file.
May 10 2018, 12:56 PM
trixirt added inline comments to D45647: Limit the MaxSteps used in hasPredessorHelper.
May 10 2018, 12:50 PM

Apr 13 2018

trixirt created D45647: Limit the MaxSteps used in hasPredessorHelper.
Apr 13 2018, 4:50 PM

Mar 27 2018

trixirt created D44964: Change order of libclang_rt.profile link for freebsd.
Mar 27 2018, 3:41 PM

Mar 13 2018

trixirt created D44447: Treat libclang_rt.* as normal library if the user uses --sysroot= .
Mar 13 2018, 2:11 PM · Restricted Project

Feb 9 2018

trixirt added a comment to D42310: Formalize FreeBSD support of compiler rt .

The symlinks were useful in the transition from gcc to clang.
Now they don't serve any purpose.
Clang uses libcompiler_rt, not libgcc.

Feb 9 2018, 5:26 PM
trixirt added a comment to D42310: Formalize FreeBSD support of compiler rt .

I think it is overkill to look for fbsd 8, it was eol-ed 2015, and 9 in 2016.
A native build of clang 7 on fbsd 8 would be difficult to pull off, needing at least 1-3 intermediate clang's/gcc's

Feb 9 2018, 5:14 PM

Jan 19 2018

trixirt created D42310: Formalize FreeBSD support of compiler rt .
Jan 19 2018, 11:51 AM

Jan 9 2018

trixirt created D41881: [analyzer] Flag bcmp, bcopy and bzero as obsolete.
Jan 9 2018, 1:20 PM

Oct 30 2017

trixirt updated the diff for D39313: Handle x86 feature specific alignment of __builtin_alloca..

Make SuitbleAlign 128 for all x86 by moving the setting to the base X86TargetInfo class
This only changes 32 bit android's value of 32

Oct 30 2017, 12:31 PM · Restricted Project

Oct 28 2017

trixirt added reviewers for D39313: Handle x86 feature specific alignment of __builtin_alloca.: tberghammer, chh.

As android 32 target is in question, adding reviewers that added the target and reviewed the addition
I believe android's SuitableAlign should be 128 like the other x86's

Oct 28 2017, 9:12 AM · Restricted Project

Oct 27 2017

trixirt updated the diff for D39313: Handle x86 feature specific alignment of __builtin_alloca..

Better handling of android x86_32
Change the SuitableAlign value only if the new value is bigger than the existing value

Oct 27 2017, 9:10 AM · Restricted Project

Oct 26 2017

trixirt added inline comments to D39313: Handle x86 feature specific alignment of __builtin_alloca..
Oct 26 2017, 12:33 PM · Restricted Project

Oct 25 2017

trixirt created D39313: Handle x86 feature specific alignment of __builtin_alloca..
Oct 25 2017, 5:50 PM · Restricted Project

Jun 29 2017

trixirt created D34843: Make NumOperands and getNumOperands types be consistent..
Jun 29 2017, 4:09 PM

Mar 13 2017

trixirt added a comment to D30389: Fix a build break with xray.

Can someone check this in ?

Mar 13 2017, 4:00 PM

Feb 26 2017

trixirt created D30389: Fix a build break with xray.
Feb 26 2017, 7:59 PM

Nov 6 2015

trixirt added a comment to D13284: [ PowerPC ] Remove FeatureMFOCRF from the e500mc ProcessorModel..

Since it has been a month between reviews, I have moved onto other things.
I would hope that this change would not get stuck on the semantics of
the testcase.
The e500 is broken without this change.
Tom

Nov 6 2015, 11:22 AM

Oct 4 2015

trixirt updated the diff for D13142: [PowerPC] Replace cntlz[.] with cntlzw[.].

improve commit log to explain long use of cntlz is why this POWER mnemonic is supported.

Oct 4 2015, 9:19 AM
trixirt updated the diff for D13284: [ PowerPC ] Remove FeatureMFOCRF from the e500mc ProcessorModel..

A testcase distilled from the original problem.
Checks that mfocrf is not used.
Since checking for something not present is brittle, add a positve check.
The second check appends -mattr+mfocrf to the compile arg.
This manually adds back the removed feature and the generated code is
checked for the mfocrf insn.

Oct 4 2015, 8:53 AM

Sep 30 2015

trixirt added a comment to D13284: [ PowerPC ] Remove FeatureMFOCRF from the e500mc ProcessorModel..

Yes.
I will whip something up.
Tom

Sep 30 2015, 5:40 PM
trixirt retitled D13284: [ PowerPC ] Remove FeatureMFOCRF from the e500mc ProcessorModel. from to [ PowerPC ] Remove FeatureMFOCRF from the e500mc ProcessorModel..
Sep 30 2015, 5:35 AM

Sep 27 2015

trixirt updated the diff for D13142: [PowerPC] Replace cntlz[.] with cntlzw[.].

Added alias back to old cntlz mnemonic.
So old, stand alone assembly programs will still work.

Sep 27 2015, 9:48 AM

Sep 24 2015

trixirt retitled D13142: [PowerPC] Replace cntlz[.] with cntlzw[.] from to [PowerPC] Replace cntlz[.] with cntlzw[.].
Sep 24 2015, 11:07 AM

May 28 2015

trixirt added a comment to D9170: Add support for FreeBSD arm live debugging.

There is also a change to support core file reading, that I believe is
ready.
http://reviews.llvm.org/D9292

May 28 2015, 6:02 AM

May 3 2015

trixirt updated the test plan for D9170: Add support for FreeBSD arm live debugging.
May 3 2015, 10:37 AM
trixirt updated the diff for D9170: Add support for FreeBSD arm live debugging.

Handle thumb breakpoints
Detect when in thumb code and silently disable breakpoints
FreeBSD does not support thumb breakpoints.
Define a reasonable breakpoint instruction to enable when thumb breakpoints are supported

May 3 2015, 10:35 AM

Apr 29 2015

trixirt updated the diff for D9292: A better initializing the OSType in elf object file's arch_spec.

Move ObjectFileELF::GetOsFromOSABI functionality to ArchSpec::SetArchitecture

Apr 29 2015, 6:11 AM
trixirt added a comment to D9292: A better initializing the OSType in elf object file's arch_spec.

It seems like GetOsFromOSABI's purpose is to compensate for
ArchSpec::SetArchitecture. I think it would be better to improve
SetArchitecture. I will post a change showing how this could be done
shorty.
Tom

Apr 29 2015, 6:03 AM

Apr 27 2015

trixirt added a comment to D9292: A better initializing the OSType in elf object file's arch_spec.

I believe that an 'unknown' vendor is normal for some triples.
For example i386-unknown-freebsd10.1

Apr 27 2015, 10:46 AM
trixirt retitled D9292: A better initializing the OSType in elf object file's arch_spec from to A better initializing the OSType in elf object file's arch_spec.
Apr 27 2015, 7:23 AM

Apr 21 2015

trixirt updated subscribers of D9170: Add support for FreeBSD arm live debugging.
Apr 21 2015, 1:06 PM
trixirt retitled D9170: Add support for FreeBSD arm live debugging from to Add support for FreeBSD arm live debugging.
Apr 21 2015, 1:04 PM