This is an archive of the discontinued LLVM Phabricator instance.

[Modules] Add test for merging of template member parent
ClosedPublic

Authored by Hahnfeld on Aug 1 2023, 9:36 AM.

Details

Summary

This is a reduced test case originally meant to be addressed by https://reviews.llvm.org/D137787. It was recently fixed by commit rG61c7a9140b ("Commit to a primary definition for a class when we load its first member."), noting the difficulty to come up with a reduced test case. This setup with four modules seems to fail consistently before the fix mentioned above.

Diff Detail

Event Timeline

Hahnfeld created this revision.Aug 1 2023, 9:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2023, 9:36 AM
Hahnfeld requested review of this revision.Aug 1 2023, 9:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2023, 9:36 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rsmith accepted this revision.Aug 1 2023, 11:04 AM

Awesome, thanks! It makes perfect sense that rG61c7a9140b would fix this.

This revision is now accepted and ready to land.Aug 1 2023, 11:04 AM
ChuanqiXu accepted this revision.Aug 1 2023, 6:48 PM

LGTM. Thanks.

This revision was automatically updated to reflect the committed changes.