This is an archive of the discontinued LLVM Phabricator instance.

[clang][hexagon] Handle library path arguments earlier
ClosedPublic

Authored by bcain on Jul 31 2023, 7:54 PM.

Details

Summary

The removal of the early return in 96832a6bf7e0e7f1e8d634d38c44a1b32d512923
was an error: it would include the 'standalone' library that's not used
by linux.

Instead we reproduce the library path handling in the linux/musl block.

Diff Detail

Event Timeline

bcain created this revision.Jul 31 2023, 7:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2023, 7:54 PM
bcain requested review of this revision.Jul 31 2023, 7:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2023, 7:54 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

(After D156363, newer tests can use -### -Werror instead of -fdriver-only -v -Werror :) )

bcain updated this revision to Diff 546314.Aug 1 2023, 9:53 PM

Changed test to use -Werror -### instead of -fdriver-only -v -Werror.

Fixed indentation / clang-format.

bcain added a comment.Aug 3 2023, 7:21 PM

ping? any concerns about this change?

This revision was not accepted when it landed; it landed in state Needs Review.Aug 7 2023, 6:22 PM
This revision was automatically updated to reflect the committed changes.