This is an archive of the discontinued LLVM Phabricator instance.

[bazel] Update example workspace files with dependencies
ClosedPublic

Authored by aidengrossman on Jul 31 2023, 1:42 AM.

Details

Summary

Currently, the example workspace files do not work properly. The llvm_disable_optional_support_deps option was removed in 7b5d6cd and zlib and zstd have been needed-by-default dependencies for a while, so it would make sense to show definitions in the example bazel workspace files, especially given the version sensitivity of the zlib-ng build. This patch removes the use of dated build config flags and adds dependency definitions to both of the example workspaces.

Diff Detail

Event Timeline

aidengrossman created this revision.Jul 31 2023, 1:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2023, 1:42 AM
aidengrossman requested review of this revision.Jul 31 2023, 1:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2023, 1:42 AM
aaronmondal accepted this revision.Jul 31 2023, 8:53 PM

Thanks a lot for this! This is something I should've done after the zlib changes but I completely forgot about it 😰

If the LLVM commit in these examples is recent enough for this change I'm fine with it. If not, it would probably be good to bump that to a more recent commit so that a naive copy-paste of these examples works.

Otherwise LGTM :)

This revision is now accepted and ready to land.Jul 31 2023, 8:53 PM