Currently, the example workspace files do not work properly. The llvm_disable_optional_support_deps option was removed in 7b5d6cd and zlib and zstd have been needed-by-default dependencies for a while, so it would make sense to show definitions in the example bazel workspace files, especially given the version sensitivity of the zlib-ng build. This patch removes the use of dated build config flags and adds dependency definitions to both of the example workspaces.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Thanks a lot for this! This is something I should've done after the zlib changes but I completely forgot about it 😰
If the LLVM commit in these examples is recent enough for this change I'm fine with it. If not, it would probably be good to bump that to a more recent commit so that a naive copy-paste of these examples works.
Otherwise LGTM :)