This is an archive of the discontinued LLVM Phabricator instance.

[Clang][Frontend] Change help text for --offload-host-device
ClosedPublic

Authored by AntonRydahl on Jul 30 2023, 8:06 PM.

Details

Summary

I believe the help text for the flag --offload-host-device is wrong. Currently, the help text says "Only compile for the offloading host." but the flag alias with --cuda-compile-host-device which
has the help text "Compile CUDA code for both host and device (default). Has no effect on non-CUDA compilations."

Diff Detail

Event Timeline

AntonRydahl created this revision.Jul 30 2023, 8:06 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
AntonRydahl requested review of this revision.Jul 30 2023, 8:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2023, 8:06 PM

The tests that failed pass locally on my machine.

The tests that failed pass locally on my machine.

If the tests are clearly not related to your change, assume they are broken before or flaky.

jdoerfert accepted this revision.Jul 31 2023, 11:42 AM
This revision is now accepted and ready to land.Jul 31 2023, 11:42 AM

Running tests again.

Rebased on latest commit from main.