This is an archive of the discontinued LLVM Phabricator instance.

[libc++][test] Fixes using modules in the test suite.
ClosedPublic

Authored by Mordante on Jul 28 2023, 8:44 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rGd7915c8aa950: [libc++][test] Fixes using modules in the test suite.
Summary

Importing modules in the test suite failed due to linker errors. This
fixes the issue and adds a minimal test to validate importing the std
module works.

Diff Detail

Event Timeline

Mordante created this revision.Jul 28 2023, 8:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2023, 8:44 AM
Herald added a subscriber: arichardson. · View Herald Transcript
Mordante requested review of this revision.Jul 28 2023, 8:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2023, 8:44 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik added inline comments.
libcxx/test/std/modules/std.pass.cpp
11

This isn't expected to fail in C++26, right? Could you add a TODO for fixing this?

libcxx/utils/libcxx/test/dsl.py
460

What does the -v do?

Mordante updated this revision to Diff 545351.Jul 29 2023, 2:06 AM

Rebased to trigger CI.

Mordante added inline comments.Jul 29 2023, 5:21 AM
libcxx/utils/libcxx/test/dsl.py
460

verbose output. In the end I hope all this code can become part of CMake. For now it's easier to debug.

philnik accepted this revision.Jul 31 2023, 8:27 AM

LGTM with TODOs added.

libcxx/utils/libcxx/test/dsl.py
461–463

Please add a TODO to fix this.

This revision is now accepted and ready to land.Jul 31 2023, 8:27 AM
Mordante marked 3 inline comments as done.Jul 31 2023, 9:36 AM
This revision was landed with ongoing or failed builds.Jul 31 2023, 9:37 AM
This revision was automatically updated to reflect the committed changes.