This is an archive of the discontinued LLVM Phabricator instance.

[libc++][modules] Fixes exporting named declarations.
ClosedPublic

Authored by Mordante on Jul 29 2023, 4:21 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rGe57f6f709ed2: [libc++][modules] Fixes exporting named declarations.
Summary

@ChuanqiXu noticed std::atomic was not properly exported in the std module.
Investigation showed other named declarations were not exported either. This
fixes the issue.

Depends on D156550

Diff Detail

Event Timeline

Mordante created this revision.Jul 29 2023, 4:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2023, 4:21 AM
Mordante published this revision for review.Jul 30 2023, 3:48 AM

Note this patch is a minimal fix intended to be backported to LLVM-17. The tests are in D156594.

Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2023, 3:48 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.Jul 31 2023, 8:31 AM
This revision is now accepted and ready to land.Jul 31 2023, 8:31 AM
This revision was automatically updated to reflect the committed changes.