This is an archive of the discontinued LLVM Phabricator instance.

[TestSuite][OpenMP] Update expected pass list for external SOLLVE V&V test suite
AcceptedPublic

Authored by AaronLiu20 on Jul 28 2023, 8:22 AM.

Details

Event Timeline

AaronLiu20 created this revision.Jul 28 2023, 8:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2023, 8:22 AM
AaronLiu20 requested review of this revision.Jul 28 2023, 8:22 AM
jdoerfert retitled this revision from added suggestions from 5 runs of the sollve vv testsuite runs to the whitelist to [TestSuite][OpenMP] Update expected pass list for external SOLLVE V&V test suite.Jul 28 2023, 9:38 AM

Thank you for the update. Please allow me some time to test the changes on my machine.

Meinersbur added a comment.EditedAug 2 2023, 9:16 AM

I get the following failures with this path on latest clang (rGd6f1880c629d629d03914ad564b4d7b188ada444):

********************
Failed Tests (7):
  test-suite :: External/sollve_vv/omptargetvv-test_loop_order_reproducible-51_order-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_omp_num_teams_env_2-51_env_var-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_omp_places_env_ll_caches-51_env_var-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_omp_places_env_numa_domains-51_env_var-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_omp_teams_thread_limit_env_2-51_env_var-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_taskwait_depend-50_taskwait-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_teams_region_routines-51_runtime_calls-c.test

********************
Executable Missing Tests (6):
  test-suite :: External/sollve_vv/omptargetvv-test_declare_target_enter-52_declare_target-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_declare_target_enter_device_type_any-52_declare_target-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_declare_target_enter_device_type_host-52_declare_target-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_declare_target_enter_device_type_nohost-52_declare_target-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_declare_target_enter_device_type_nohost1-52_declare_target-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_target_enter_data_map-52_target_enter_data-c.test

Failure log:

That this is a relatively old Nvidia Quadro P 600 (sm_61), the idea being to not regress on older hardware. In the short term, the easy way out is to just remove all those tests above from the whitelist.

The compile tests unfortunately seem to depend on -fopenmp-version. With -fopenmp-version=52 even more tests fail to compile:

********************
Executable Missing Tests (9):
  test-suite :: External/sollve_vv/omptargetvv-test_declare_target_device_type_any-50_declare_target-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_declare_target_device_type_host-50_declare_target-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_declare_target_device_type_nohost-50_declare_target-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_declare_target_to_extended_list-45_declare_target-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_depobj_depend_update_destroy-50_depobj-cpp.test
  test-suite :: External/sollve_vv/omptargetvv-test_nested_declare_target-50_declare_target-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_target_in_reduction-50_target-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_target_memcpy_async_depobj-51_target-c.test
  test-suite :: External/sollve_vv/omptargetvv-test_target_memcpy_rect_async_depobj-51_target-c.test

Possibly we need different whitelists with different -fopenmp-version arguments, as indicated by the SOLLVE V&V version.

update the whitelist based on the results from Perlmutter A100, link the math library to all the codes, updating the default compiler/linker flags based on the clang 18"

jarmusch accepted this revision.Sep 5 2023, 1:28 PM
jarmusch added a subscriber: jarmusch.

looks good

This revision is now accepted and ready to land.Sep 5 2023, 1:28 PM