[MemProf] Convert PGO raw profile to text format

[tejohnson]

Summary

This avoids the need to regenerate the PGO raw profile on version
changes.

[snehasish]

Can you also update llvm/test/Transforms/PGOProfile/Inputs/update_memprof_inputs.sh which generates the profraw today?

[tejohnson]

Address comments

[tejohnson]

In D156460#4539627, @snehasish wrote:

Can you also update llvm/test/Transforms/PGOProfile/Inputs/update_memprof_inputs.sh which generates the profraw today?

Done and confirmed it works as expected.

[snehasish]

lgtm

llvm/test/Transforms/PGOProfile/Inputs/memprof_pgo.proftext

+# IR level Instrumentation Flag
+:ir
+_Z3barv
+# Func Hash:
+742261418966908927
+# Num Counters:
+1
+# Counter Values:
+1
+
+_Z3bazv
+# Func Hash:
+742261418966908927
+# Num Counters:
+1
+# Counter Values:
+1
+
+_Z3foov
+# Func Hash:
+742261418966908927
+# Num Counters:
+1
+# Counter Values:
+6
+
+_Z4foo2v
+# Func Hash:
+742261418966908927
+# Num Counters:
+1
+# Counter Values:
+2
+
+_Z7recursej
+# Func Hash:
+146835647075900052
+# Num Counters:
+2
+# Counter Values:
+7
+2
+
+main
+# Func Hash:
+303685788594980264
+# Num Counters:
+10
+# Counter Values:
+2
+2
+1
+1
+1
+1
+1
+1
+1
+1
+

llvm/test/Transforms/PGOProfile/Inputs/update_memprof_inputs.sh

 #!/bin/bash
 
-if [ -z $1 ]; then
-  echo "Path to clang required!"
-  echo "Usage: update_memprof_inputs.sh /path/to/updated/clang"
+if [ $# -lt 2 ]; then
+  echo "Path to clang and llvm-profdata required!"
+  echo "Usage: update_memprof_inputs.sh /path/to/updated/clang /path/to/updated/llvm-profdata"
   exit 1
 else
   CLANG=$1
+  LLVMPROFDATA=$2
 fi
 
 # Allows the script to be invoked from other directories.
 OUTDIR=$(dirname $(realpath -s $0))
 
 # Note that changes in the code below which affect relative line number
 # offsets of calls from their parent function can affect callsite matching in
 # the LLVM IR.

 COMMON_FLAGS="-fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -Wl,-build-id -no-pie"
 
 ${CLANG} ${COMMON_FLAGS} -fmemory-profile ${OUTDIR}/memprof.cc -o ${OUTDIR}/memprof.exe
 env MEMPROF_OPTIONS=log_path=stdout ${OUTDIR}/memprof.exe > ${OUTDIR}/memprof.memprofraw
 
 ${CLANG} ${COMMON_FLAGS} -fprofile-generate=. \
   ${OUTDIR}/memprof.cc -o ${OUTDIR}/pgo.exe
 env LLVM_PROFILE_FILE=${OUTDIR}/memprof_pgo.profraw ${OUTDIR}/pgo.exe
+${LLVMPROFDATA} merge --text ${OUTDIR}/memprof_pgo.profraw -o ${OUTDIR}/memprof_pgo.proftext
 
 rm ${OUTDIR}/memprof.cc
 rm ${OUTDIR}/pgo.exe
+rm ${OUTDIR}/memprof_pgo.profraw

llvm/test/Transforms/PGOProfile/memprof.ll

 ;; Tests memprof profile matching (with and without instrumentation profiles).
 
 ;; Several requirements due to using raw profile inputs:
 ;; PGO profile uses zlib compression
 ; REQUIRES: zlib
 ;; Avoid failures on big-endian systems that can't read the profile properly
 ; REQUIRES: x86_64-linux
 
 ;; TODO: Use text profile inputs once that is available for memprof.
 ;; # To update the Inputs below, run Inputs/update_memprof_inputs.sh.
 ;; # To generate below LLVM IR for use in matching:
 ;; $ clang++ -gmlt -fdebug-info-for-profiling -fno-omit-frame-pointer \
 ;;  -fno-optimize-sibling-calls memprof.cc -S -emit-llvm
 
 ;; Generate indexed profiles of all combinations:
 ; RUN: llvm-profdata merge %S/Inputs/memprof.memprofraw --profiled-binary %S/Inputs/memprof.exe -o %t.memprofdata
-; RUN: llvm-profdata merge %S/Inputs/memprof_pgo.profraw %S/Inputs/memprof.memprofraw --profiled-binary %S/Inputs/memprof.exe -o %t.pgomemprofdata
-; RUN: llvm-profdata merge %S/Inputs/memprof_pgo.profraw -o %t.pgoprofdata
+; RUN: llvm-profdata merge %S/Inputs/memprof_pgo.proftext %S/Inputs/memprof.memprofraw --profiled-binary %S/Inputs/memprof.exe -o %t.pgomemprofdata
+; RUN: llvm-profdata merge %S/Inputs/memprof_pgo.proftext -o %t.pgoprofdata
 
 ;; In all below cases we should not get any messages about missing profile data
 ;; for any functions. Either we are not performing any matching for a particular
 ;; profile type or we are performing the matching and it should be successful.
 ; ALL-NOT: memprof record not found for function hash
 ; ALL-NOT: no profile data available for function
 
 ;; Using a memprof-only profile for memprof-use should only give memprof metadata