This is an archive of the discontinued LLVM Phabricator instance.

[mlir] use a thread-local alternative to llvm::nulls
ClosedPublic

Authored by ftynse on Jul 27 2023, 5:14 AM.

Details

Summary

LLVM is not set up in a thread-safe way, which seems to be leading to
race conditions when sending stuff to llvm::nulls in opt builds. Try a
thread-local alternative.

Diff Detail

Event Timeline

ftynse created this revision.Jul 27 2023, 5:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2023, 5:14 AM
ftynse requested review of this revision.Jul 27 2023, 5:14 AM
pzread accepted this revision.EditedJul 28 2023, 10:26 AM

LGTM, but might have someone else who is familiar with it to take another look

This revision is now accepted and ready to land.Jul 28 2023, 10:26 AM
This revision was automatically updated to reflect the committed changes.

Why wouldn't this go to LLVM Support?