This is an archive of the discontinued LLVM Phabricator instance.

[libc] _INCLUDE_SCUDO: check for compiler-rt in enabled RUNTIMES too
ClosedPublic

Authored by alfredfo on Jul 26 2023, 6:34 PM.

Details

Summary

Previously including SCUDO in a libc build with runtimes/ as root was
not possible since this code only checked for compiler-rt enabled via
LLVM_ENABLED_PROJECTS.

Diff Detail

Event Timeline

alfredfo created this revision.Jul 26 2023, 6:34 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 26 2023, 6:34 PM
alfredfo requested review of this revision.Jul 26 2023, 6:34 PM
thesamesam accepted this revision.Jul 26 2023, 7:41 PM
thesamesam added inline comments.
libc/CMakeLists.txt
167–168

Maybe tweak this, but I don't feel super strongly about it.

This revision is now accepted and ready to land.Jul 26 2023, 7:41 PM
alfredfo updated this revision to Diff 544582.Jul 26 2023, 8:47 PM

change msg