Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

alfredfo (Alfred Persson Forsberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 11 2023, 6:25 PM (24 w, 2 d)

Recent Activity

Oct 19 2023

alfredfo committed rG67770cbb9841: [libc][NFC] Fix features.h.def file header (authored by alfredfo).
[libc][NFC] Fix features.h.def file header
Oct 19 2023, 11:01 AM · Restricted Project, Restricted Project

Sep 3 2023

alfredfo committed rGb12385f3aa56: [libc] [NFC] wait4Impl: include <signal.h> instead of <sys/signal.h> (authored by alfredfo).
[libc] [NFC] wait4Impl: include <signal.h> instead of <sys/signal.h>
Sep 3 2023, 4:51 PM · Restricted Project, Restricted Project

Aug 16 2023

alfredfo added a reverting change for rG0fb3066873fd: [libc] Add limits.h: rGd3e045934a3d: Revert "[libc] Add limits.h".
Aug 16 2023, 9:25 PM · Restricted Project, Restricted Project
alfredfo added a reverting change for rG002cba03298a: [libc] limits.h: include compiler limits if not already included: rGd3e045934a3d: Revert "[libc] Add limits.h".
Aug 16 2023, 9:24 PM · Restricted Project, Restricted Project
alfredfo added a reverting change for rG13bbca8d694b: [libc] [NFC] explain compiler macros in limits.h: rGd3e045934a3d: Revert "[libc] Add limits.h".
Aug 16 2023, 9:24 PM · Restricted Project, Restricted Project
alfredfo committed rGd3e045934a3d: Revert "[libc] Add limits.h" (authored by alfredfo).
Revert "[libc] Add limits.h"
Aug 16 2023, 9:24 PM · Restricted Project, Restricted Project
alfredfo added a reverting change for D156961: [libc] Add limits.h: rGd3e045934a3d: Revert "[libc] Add limits.h".
Aug 16 2023, 9:24 PM · Restricted Project, Restricted Project
alfredfo added a reverting change for D158040: [libc] limits.h: include compiler limits if not already included: rGd3e045934a3d: Revert "[libc] Add limits.h".
Aug 16 2023, 9:24 PM · Restricted Project, Restricted Project
alfredfo added a reverting change for D158128: [libc] [NFC] explain compiler macros in limits.h: rGd3e045934a3d: Revert "[libc] Add limits.h".
Aug 16 2023, 9:24 PM · Restricted Project, Restricted Project
alfredfo committed rG13bbca8d694b: [libc] [NFC] explain compiler macros in limits.h (authored by alfredfo).
[libc] [NFC] explain compiler macros in limits.h
Aug 16 2023, 4:24 PM · Restricted Project, Restricted Project
alfredfo closed D158128: [libc] [NFC] explain compiler macros in limits.h.
Aug 16 2023, 4:23 PM · Restricted Project, Restricted Project
alfredfo requested review of D158128: [libc] [NFC] explain compiler macros in limits.h.
Aug 16 2023, 4:15 PM · Restricted Project, Restricted Project

Aug 15 2023

alfredfo updated the diff for D153396: WIP: [libc] Add fdopen for linux targets.

add a simple test (more needed)

Aug 15 2023, 9:33 PM · Restricted Project, Restricted Project
alfredfo updated the diff for D153396: WIP: [libc] Add fdopen for linux targets.

refactor into separate allocatefile function

Aug 15 2023, 9:17 PM · Restricted Project, Restricted Project
alfredfo updated the diff for D158040: [libc] limits.h: include compiler limits if not already included.

move out of linux check

Aug 15 2023, 4:52 PM · Restricted Project, Restricted Project
alfredfo updated the diff for D158040: [libc] limits.h: include compiler limits if not already included.

s/fi/endif

Aug 15 2023, 4:48 PM · Restricted Project, Restricted Project
alfredfo requested review of D158040: [libc] limits.h: include compiler limits if not already included.
Aug 15 2023, 4:46 PM · Restricted Project, Restricted Project
alfredfo updated the diff for D153396: WIP: [libc] Add fdopen for linux targets.

make openfile(char*,char*) use new overload

Aug 15 2023, 3:00 PM · Restricted Project, Restricted Project
alfredfo updated the diff for D153396: WIP: [libc] Add fdopen for linux targets.

u

Aug 15 2023, 2:30 PM · Restricted Project, Restricted Project
alfredfo added inline comments to D157821: [libc] add fileno function for Linux.
Aug 15 2023, 1:53 PM · Restricted Project, Restricted Project
alfredfo added a comment to D157821: [libc] add fileno function for Linux.

@sivachandra: Yes, I also wondered about that (re: "Linux implementation does not try to check if stream is actually a file stream"). I don't know what the best solution is. I tried both glibc and llvm-libc with invalid stream as argument and both crashed. Seems like musl libc also just assumes that the file ptr is valid https://elixir.bootlin.com/musl/latest/source/src/stdio/fileno.c#L7

Aug 15 2023, 1:50 PM · Restricted Project, Restricted Project
alfredfo updated the diff for D157821: [libc] add fileno function for Linux.

add tests

Aug 15 2023, 1:45 PM · Restricted Project, Restricted Project

Aug 14 2023

alfredfo updated the diff for D157821: [libc] add fileno function for Linux.

fix format

Aug 14 2023, 1:53 PM · Restricted Project, Restricted Project

Aug 13 2023

alfredfo updated the diff for D157824: [libc] Define __UTS_NAME_LENGTH for __APPLE__.

update commit message

Aug 13 2023, 5:48 PM · Restricted Project, Restricted Project
alfredfo updated the diff for D156961: [libc] Add limits.h.

update message

Aug 13 2023, 5:35 PM · Restricted Project, Restricted Project
alfredfo updated the diff for D156961: [libc] Add limits.h.

arc broken moment

Aug 13 2023, 5:29 PM · Restricted Project, Restricted Project
alfredfo updated the diff for D156961: [libc] Add limits.h.

update msg

Aug 13 2023, 5:08 PM · Restricted Project, Restricted Project
alfredfo requested review of D157824: [libc] Define __UTS_NAME_LENGTH for __APPLE__.
Aug 13 2023, 12:32 PM · Restricted Project, Restricted Project
alfredfo requested review of D157821: [libc] add fileno function for Linux.
Aug 13 2023, 11:40 AM · Restricted Project, Restricted Project

Aug 10 2023

alfredfo published D153396: WIP: [libc] Add fdopen for linux targets for review.
Aug 10 2023, 4:31 PM · Restricted Project, Restricted Project
alfredfo updated the diff for D156961: [libc] Add limits.h.

only define SSIZE_MAX if not already defined

Aug 10 2023, 4:17 PM · Restricted Project, Restricted Project
alfredfo added inline comments to D156961: [libc] Add limits.h.
Aug 10 2023, 4:15 PM · Restricted Project, Restricted Project
alfredfo updated the diff for D156961: [libc] Add limits.h.

remove PATH_MAX definition

Aug 10 2023, 4:08 PM · Restricted Project, Restricted Project

Aug 4 2023

alfredfo added a comment to D156961: [libc] Add limits.h.

Yeah prob should be provided by both :)

Aug 4 2023, 1:30 AM · Restricted Project, Restricted Project
alfredfo added a comment to D156961: [libc] Add limits.h.

The limits.h header is provided by the compiler, so us providing it will just cause problems

Aug 4 2023, 1:27 AM · Restricted Project, Restricted Project

Aug 2 2023

alfredfo requested review of D156961: [libc] Add limits.h.
Aug 2 2023, 7:40 PM · Restricted Project, Restricted Project
alfredfo abandoned D156960: [libc] Add limits.h.
Aug 2 2023, 7:39 PM · Restricted Project, Restricted Project
alfredfo requested review of D156960: [libc] Add limits.h.
Aug 2 2023, 7:30 PM · Restricted Project, Restricted Project

Jul 26 2023

alfredfo updated the diff for D156388: [libc] _INCLUDE_SCUDO: check for compiler-rt in enabled RUNTIMES too.

change msg

Jul 26 2023, 8:47 PM · Restricted Project, Restricted Project
alfredfo requested review of D156388: [libc] _INCLUDE_SCUDO: check for compiler-rt in enabled RUNTIMES too.
Jul 26 2023, 6:34 PM · Restricted Project, Restricted Project

Jul 25 2023

alfredfo requested review of D156276: [libc] pthread.h.def: add PTHREAD_MUTEX_INITIALIZER.
Jul 25 2023, 4:44 PM · Restricted Project, Restricted Project
alfredfo accepted D156275: [libc] Add back report_assertion_failure.
Jul 25 2023, 4:34 PM · Restricted Project, Restricted Project
alfredfo accepted D156264: [libc] Move public assert to macro printing.
Jul 25 2023, 4:21 PM · Restricted Project, Restricted Project

Jun 26 2023

alfredfo added a comment to D153729: [libc] Correct usage of __unix__ and __linux__.

LGTM, but...

Here are things still using __unix__, and I'm pretty sure those are correct.

All of them seem to be related to the Linux futex word. Wouldn't __linux__ be the most appropriate for them as well?

Jun 26 2023, 1:24 PM · Restricted Project, Restricted Project
alfredfo updated the diff for D153729: [libc] Correct usage of __unix__ and __linux__.

added Linux specific futex word

Jun 26 2023, 1:23 PM · Restricted Project, Restricted Project
alfredfo added a comment to D153729: [libc] Correct usage of __unix__ and __linux__.

LGTM, but...

Here are things still using __unix__, and I'm pretty sure those are correct.

All of them seem to be related to the Linux futex word. Wouldn't __linux__ be the most appropriate for them as well?

Jun 26 2023, 4:11 AM · Restricted Project, Restricted Project

Jun 25 2023

alfredfo updated the diff for D153729: [libc] Correct usage of __unix__ and __linux__.

another one (__support/threads/mutex.h)

Jun 25 2023, 4:17 PM · Restricted Project, Restricted Project
alfredfo added a comment to D153729: [libc] Correct usage of __unix__ and __linux__.

Here are things still using __unix__, and I'm pretty sure those are correct.

Jun 25 2023, 4:03 PM · Restricted Project, Restricted Project
alfredfo requested review of D153729: [libc] Correct usage of __unix__ and __linux__.
Jun 25 2023, 4:00 PM · Restricted Project, Restricted Project

Jun 18 2023

alfredfo requested review of D153231: [libc] [NFC] malloc.h: fix include guard typo.
Jun 18 2023, 3:05 PM · Restricted Project, Restricted Project

Jun 15 2023

alfredfo updated the diff for D152979: [scudo] Do not compile timing.cpp if LLVM_LIBC_INCLUDE_SCUDO=on.

Skip timing_test.cpp if LLVM_LIBC_INCLUDE_SCUDO=on too

Jun 15 2023, 7:43 AM · Restricted Project, Restricted Project

Jun 14 2023

alfredfo requested review of D152979: [scudo] Do not compile timing.cpp if LLVM_LIBC_INCLUDE_SCUDO=on.
Jun 14 2023, 4:12 PM · Restricted Project, Restricted Project

Jun 11 2023

alfredfo updated the diff for D152664: [libc] Fix argument types for {f,}truncate specs.

[libc] Fix argument types for {f,}truncate specs

Jun 11 2023, 7:30 PM · Restricted Project, Restricted Project
alfredfo requested review of D152664: [libc] Fix argument types for {f,}truncate specs.
Jun 11 2023, 7:03 PM · Restricted Project, Restricted Project