This is an archive of the discontinued LLVM Phabricator instance.

Outputs parameter comments using clang-doc and markdown generator
ClosedPublic

Authored by BotellaA on Jul 26 2023, 5:18 AM.

Details

Summary

Current implementation outputs the parameter name when used with @param (or @tparam) doxygen tag but not the comment itself.

Diff Detail

Event Timeline

BotellaA created this revision.Jul 26 2023, 5:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2023, 5:18 AM
BotellaA requested review of this revision.Jul 26 2023, 5:18 AM
BotellaA updated this revision to Diff 544477.EditedJul 26 2023, 12:47 PM

I updated the expected result in the MD generator test.
There was already a comment for some parameters but they were not outputted and not included in the test

aaron.ballman accepted this revision.Jul 27 2023, 9:15 AM

I'm not a typical reviewer for clang-doc, so take this with a grain of salt, but LGTM! Do you need someone to land the changes on your behalf? If so, what name and email address would you like used for patch attribution? (I'll leave the review up for a few days in case other reviewers have comments.)

This revision is now accepted and ready to land.Jul 27 2023, 9:15 AM

Thanks.
You can use this name Arnaud Botella with this email arnaud.botella@geode-solutions.com.