This is an archive of the discontinued LLVM Phabricator instance.

[libc++][doc] Updates format related release notes.
ClosedPublic

Authored by Mordante on Jul 22 2023, 8:47 AM.

Details

Summary

As suggested by @ldionne.

Diff Detail

Event Timeline

Mordante created this revision.Jul 22 2023, 8:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2023, 8:47 AM
Mordante requested review of this revision.Jul 22 2023, 8:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2023, 8:47 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Thanks a lot for all the work you have put into implementing std::format and std::print! It's amazing to see this coming together!

libcxx/docs/ReleaseNotes/17.rst
43

Does it make sense to also mention C++23 improvements and std::print?

62

should this be moved down into the format specific section?

65

move down?

66

move down?

69

move into new section?

90–91

I didn't hear the term "main library" before. Is it supposed to be the opposite of "experimental library"? I think that most users didn't use the experimental library before and might even know of its existence. Hopefully the suggested edit is easier to understand?

93

Should the comment on https://libcxx.llvm.org/Status/Cxx20.html#note-p0645 also be updated?

Or maybe just update the versions from 14.0 to 17.0 and remove the note completely?

Same for P1652, P1892, P1868, P2216, P2418

99

The page https://libcxx.llvm.org/Status/Cxx23.html seems to be missing a note for P2286R8 and P2508R1 that they were so far experimental, and claims they were already available in 15.0/16.0

Update both to 17.0?

101

Should we also mention the (partial) implementation of P2585R0?

avogelsgesang added inline comments.Jul 22 2023, 2:36 PM
libcxx/docs/ReleaseNotes/17.rst
101

Wrong paper number...
I meant P2093R14, i.e. std::print

Thanks a lot for the feedback! I'll keep this open for Louis to comment. We can always merge documentation updates directly on the release branch.

libcxx/docs/ReleaseNotes/17.rst
43

Yes I noticed that omission after I uploaded the patch and I didn't want to run the CI again.

62

I prefer to keep the things really new in this section. For users of -fexperimental-library this is a new feature.

90–91

Thanks. I was not completely happy with the previous wording too. I like your suggestion.

93

I will update the note. For now I keep the version number as is. Since we now use the experimental library more often we need to figure out a way how we can properly document this. IIRC for ranges we basically didn't update much.

99

Good point. As above we need to discuss how to mark experimental parts in the future.

Mordante marked 10 inline comments as done.Aug 7 2023, 9:47 AM
Mordante added inline comments.
libcxx/docs/ReleaseNotes/17.rst
101

I did that above.

Mordante updated this revision to Diff 547828.Aug 7 2023, 9:48 AM
Mordante marked an inline comment as done.

Address review comments and rebased.

ldionne accepted this revision.Aug 7 2023, 12:59 PM
This revision is now accepted and ready to land.Aug 7 2023, 12:59 PM

Remember this needs to be cherry-picked to release/17.x or it won't take effect! Thanks!

avogelsgesang accepted this revision.Aug 7 2023, 1:23 PM
avogelsgesang added inline comments.
libcxx/docs/ReleaseNotes/17.rst
77–79
Mordante marked an inline comment as done.Aug 9 2023, 10:03 AM

Thanks for the reviews, I'll make a backport request later today.

This revision was landed with ongoing or failed builds.Aug 9 2023, 10:04 AM
This revision was automatically updated to reflect the committed changes.