As suggested by @ldionne.
Details
- Reviewers
ldionne avogelsgesang - Group Reviewers
Restricted Project - Commits
- rGcf83cfb3a569: [libc++][doc] Updates format related release notes.
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Thanks a lot for all the work you have put into implementing std::format and std::print! It's amazing to see this coming together!
libcxx/docs/ReleaseNotes/17.rst | ||
---|---|---|
43 | Does it make sense to also mention C++23 improvements and std::print? | |
62 | should this be moved down into the format specific section? | |
65 | move down? | |
66 | move down? | |
69 | move into new section? | |
90–91 | I didn't hear the term "main library" before. Is it supposed to be the opposite of "experimental library"? I think that most users didn't use the experimental library before and might even know of its existence. Hopefully the suggested edit is easier to understand? | |
93 | Should the comment on https://libcxx.llvm.org/Status/Cxx20.html#note-p0645 also be updated? Or maybe just update the versions from 14.0 to 17.0 and remove the note completely? Same for P1652, P1892, P1868, P2216, P2418 | |
99 | The page https://libcxx.llvm.org/Status/Cxx23.html seems to be missing a note for P2286R8 and P2508R1 that they were so far experimental, and claims they were already available in 15.0/16.0 Update both to 17.0? | |
101 | Should we also mention the (partial) implementation of P2585R0? |
libcxx/docs/ReleaseNotes/17.rst | ||
---|---|---|
101 | Wrong paper number... |
Thanks a lot for the feedback! I'll keep this open for Louis to comment. We can always merge documentation updates directly on the release branch.
libcxx/docs/ReleaseNotes/17.rst | ||
---|---|---|
43 | Yes I noticed that omission after I uploaded the patch and I didn't want to run the CI again. | |
62 | I prefer to keep the things really new in this section. For users of -fexperimental-library this is a new feature. | |
90–91 | Thanks. I was not completely happy with the previous wording too. I like your suggestion. | |
93 | I will update the note. For now I keep the version number as is. Since we now use the experimental library more often we need to figure out a way how we can properly document this. IIRC for ranges we basically didn't update much. | |
99 | Good point. As above we need to discuss how to mark experimental parts in the future. |
libcxx/docs/ReleaseNotes/17.rst | ||
---|---|---|
101 | I did that above. |
Remember this needs to be cherry-picked to release/17.x or it won't take effect! Thanks!
libcxx/docs/ReleaseNotes/17.rst | ||
---|---|---|
77–79 |
Does it make sense to also mention C++23 improvements and std::print?