This is an archive of the discontinued LLVM Phabricator instance.

[lld-macho] Implement -no_uuid
ClosedPublic

Authored by keith on Jul 19 2023, 11:08 AM.

Details

Reviewers
int3
MaskRay
Group Reviewers
Restricted Project
Commits
rGf317ce218e75: [lld-macho] Implement -no_uuid
Summary

Since UUID generation in lld is fast this is rarely used but it can be
helpful to avoid temporary issues like https://github.com/llvm/llvm-project/issues/63961

Diff Detail

Event Timeline

keith created this revision.Jul 19 2023, 11:08 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 19 2023, 11:08 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
keith requested review of this revision.Jul 19 2023, 11:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2023, 11:08 AM
MaskRay added inline comments.
lld/MachO/Config.h
231

I think we normally use a variable name of positive meaning like bool uuid = true (or maybe generateUuid?

int3 accepted this revision.Jul 19 2023, 4:21 PM
int3 added a subscriber: int3.

lgtm

lld/MachO/Config.h
231

+1 for generateUuid

This revision is now accepted and ready to land.Jul 19 2023, 4:21 PM
keith updated this revision to Diff 542242.Jul 19 2023, 4:35 PM
keith marked 2 inline comments as done.

Flip name to use the same style as other options.

MaskRay accepted this revision.Jul 19 2023, 4:36 PM
This revision was landed with ongoing or failed builds.Jul 19 2023, 4:39 PM
This revision was automatically updated to reflect the committed changes.