This is an archive of the discontinued LLVM Phabricator instance.

Differential D155722

[nfc][openacc] Add missing comma in acc dialect operation macros
ClosedPublic

Authored by razvanlupusoru on Jul 19 2023, 9:09 AM.

Details

Reviewers
clementval
vzakhari
nicolasvasilache
Commits
rG65cd3cfed220: [nfc][openacc] Add missing comma in acc dialect operation macros
Summary

A comma is missing which is incorrect if macro is used.

Diff Detail

Event Timeline

razvanlupusoru created this revision.Jul 19 2023, 9:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2023, 9:09 AM
Herald added subscribers: bviyer, sunshaoce, Moerafaat and 22 others. · View Herald Transcript
razvanlupusoru requested review of this revision.Jul 19 2023, 9:09 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptJul 19 2023, 9:10 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
clementval accepted this revision.Jul 19 2023, 9:11 AM

LGTM

This revision is now accepted and ready to land.Jul 19 2023, 9:11 AM
This revision was landed with ongoing or failed builds.Jul 19 2023, 9:12 AM
Closed by commit rG65cd3cfed220: [nfc][openacc] Add missing comma in acc dialect operation macros (authored by razvanlupusoru). · Explain Why
This revision was automatically updated to reflect the committed changes.
razvanlupusoru added a commit: rG65cd3cfed220: [nfc][openacc] Add missing comma in acc dialect operation macros.
Harbormaster completed remote builds in B246575: Diff 542059.Jul 19 2023, 9:57 AM

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
OpenACC/
4 lines

Diff 542063

mlir/include/mlir/Dialect/OpenACC/OpenACC.h

Show All 39 Lines mlir::acc::CopyinOp, mlir::acc::CreateOp, mlir::acc::PresentOp, \
mlir::acc::GetDevicePtrOp, mlir::acc::PrivateOp, \ mlir::acc::GetDevicePtrOp, mlir::acc::PrivateOp, \
mlir::acc::FirstprivateOp, mlir::acc::UpdateDeviceOp, \ mlir::acc::FirstprivateOp, mlir::acc::UpdateDeviceOp, \
mlir::acc::UseDeviceOp, mlir::acc::ReductionOp, \ mlir::acc::UseDeviceOp, mlir::acc::ReductionOp, \
mlir::acc::DeclareDeviceResidentOp, mlir::acc::DeclareLinkOp mlir::acc::DeclareDeviceResidentOp, mlir::acc::DeclareLinkOp
#define ACC_COMPUTE_CONSTRUCT_OPS \ #define ACC_COMPUTE_CONSTRUCT_OPS \
mlir::acc::ParallelOp, mlir::acc::KernelsOp, mlir::acc::SerialOp mlir::acc::ParallelOp, mlir::acc::KernelsOp, mlir::acc::SerialOp
#define ACC_DATA_CONSTRUCT_OPS \ #define ACC_DATA_CONSTRUCT_OPS \
mlir::acc::DataOp, mlir::acc::EnterDataOp, mlir::acc::ExitDataOp, \ mlir::acc::DataOp, mlir::acc::EnterDataOp, mlir::acc::ExitDataOp, \
mlir::acc::UpdateOp, mlir::acc::HostDataOp, \ mlir::acc::UpdateOp, mlir::acc::HostDataOp, mlir::acc::DeclareEnterOp, \
mlir::acc::DeclareEnterOp mlir::acc::DeclareExitOp mlir::acc::DeclareExitOp
#define ACC_COMPUTE_AND_DATA_CONSTRUCT_OPS \ #define ACC_COMPUTE_AND_DATA_CONSTRUCT_OPS \
ACC_COMPUTE_CONSTRUCT_OPS, ACC_DATA_CONSTRUCT_OPS ACC_COMPUTE_CONSTRUCT_OPS, ACC_DATA_CONSTRUCT_OPS
namespace mlir { namespace mlir {
namespace acc { namespace acc {
/// Enumeration used to encode the execution mapping on a loop construct. /// Enumeration used to encode the execution mapping on a loop construct.
/// They refer directly to the OpenACC 3.3 standard: /// They refer directly to the OpenACC 3.3 standard:
Show All 27 Lines