This check is redundant as it is covered by the call to
isPotentiallyReachable.
Depends on D155726.
Paths
| Differential D155718
[InstCombine] Remove unneeded isa<PHINode> check in foldOpIntoPhi ClosedPublic Authored by 0xdc03 on Jul 19 2023, 8:42 AM.
Details Summary This check is redundant as it is covered by the call to Depends on D155726.
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Jul 20 2023, 12:49 AM Comment Actions
Okay, I have done this and changed the patch order but the issue I have now is that no changes are visible in the tests introduced in D155726. Comment Actions
The patch order should be D155726, then D155718, then D154064. If you order the patches that way you should see a test change on SwitchTest. It's expected that you don't see a change on BranchTest, which only makes sure that D154064 doesn't regress it. 0xdc03 added a child revision: D154064: [InstructionSimplify] Limit threadCmpOverPHI recursion depth to 1.Jul 20 2023, 1:50 AM Closed by commit rGd53b3df570e3: [InstCombine] Remove unneeded isa<PHINode> check in foldOpIntoPhi (authored by 0xdc03). · Explain WhyAug 16 2023, 8:40 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 550775 llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
llvm/test/Analysis/ValueTracking/known-power-of-two-urem.ll
llvm/test/Transforms/InstCombine/icmp-fold-into-phi.ll
|