This is an archive of the discontinued LLVM Phabricator instance.

Differential D155709

[mlir][transform][linalg][python] Fix test for TileToForallOp mixin.
ClosedPublic

Authored by ingomueller-net on Jul 19 2023, 7:22 AM.

Details

Reviewers
ftynse
nicolasvasilache
Commits
rGa48d8c238f46: [mlir][transform][linalg][python] Fix test for TileToForallOp mixin.
Summary

The test was introduced recently by https://reviews.llvm.org/D155090,
but https://reviews.llvm.org/D155567, which I worked on concurrently
affected the output of that test and the two patches were never tested
together.

Diff Detail

Event Timeline

ingomueller-net created this revision.Jul 19 2023, 7:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2023, 7:22 AM
Herald added subscribers: bviyer, Moerafaat, bzcheeseman and 20 others. · View Herald Transcript
ingomueller-net requested review of this revision.Jul 19 2023, 7:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2023, 7:22 AM
Herald added subscribers: limo1996, stephenneuendorffer. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Jul 19 2023, 7:30 AM
This revision was landed with ongoing or failed builds.
Closed by commit rGa48d8c238f46: [mlir][transform][linalg][python] Fix test for TileToForallOp mixin. (authored by ingomueller-net). · Explain Why
This revision was automatically updated to reflect the committed changes.
ingomueller-net added a commit: rGa48d8c238f46: [mlir][transform][linalg][python] Fix test for TileToForallOp mixin..

Revision Contents

PathSize
mlir/
test/
python/
dialects/
8 lines

Diff 542021

mlir/test/python/dialects/transform_structured_ext.py

Show First 20 Lines • Show All 308 Lines • ▼ Show 20 Lines sequence = transform.SequenceOp(
transform.FailurePropagationMode.PROPAGATE, [], transform.AnyOpType.get() transform.FailurePropagationMode.PROPAGATE, [], transform.AnyOpType.get()
) )
with InsertionPoint(sequence.body): with InsertionPoint(sequence.body):
n = structured.MatchOp.match_op_names(sequence.bodyTarget, ["test.dummy"]) n = structured.MatchOp.match_op_names(sequence.bodyTarget, ["test.dummy"])
structured.TileToForallOp(sequence.bodyTarget, num_threads=[n, 3, 4]) structured.TileToForallOp(sequence.bodyTarget, num_threads=[n, 3, 4])
transform.YieldOp() transform.YieldOp()
# CHECK-LABEL: TEST: testTileToForallMixedDynamic # CHECK-LABEL: TEST: testTileToForallMixedDynamic
# CHECK: = transform.structured.tile_to_forall_op # CHECK: = transform.structured.tile_to_forall_op
# CHECK-SAME: num_threads [%{{.*}} : !pdl.operation, 3, 4] # CHECK-SAME: num_threads [%{{.*}} : !transform.any_op, 3, 4]
@run @run
def testTileToForallMPackedDynamic(): def testTileToForallPackedDynamic():
sequence = transform.SequenceOp( sequence = transform.SequenceOp(
transform.FailurePropagationMode.PROPAGATE, [], transform.AnyOpType.get() transform.FailurePropagationMode.PROPAGATE, [], transform.AnyOpType.get()
) )
with InsertionPoint(sequence.body): with InsertionPoint(sequence.body):
n = structured.MatchOp.match_op_names(sequence.bodyTarget, ["test.dummy"]) n = structured.MatchOp.match_op_names(sequence.bodyTarget, ["test.dummy"])
structured.TileToForallOp(sequence.bodyTarget, num_threads=n) structured.TileToForallOp(sequence.bodyTarget, num_threads=n)
transform.YieldOp() transform.YieldOp()
# CHECK-LABEL: TEST: testTileToForallMPackedDynamic # CHECK-LABEL: TEST: testTileToForallPackedDynamic
# CHECK: = transform.structured.tile_to_forall_op # CHECK: = transform.structured.tile_to_forall_op
# CHECK-SAME: num_threads *(%0 : !pdl.operation) # CHECK-SAME: num_threads *(%0 : !transform.any_op)
@run @run
def testTileToForallMapping(): def testTileToForallMapping():
sequence = transform.SequenceOp( sequence = transform.SequenceOp(
transform.FailurePropagationMode.PROPAGATE, [], transform.AnyOpType.get() transform.FailurePropagationMode.PROPAGATE, [], transform.AnyOpType.get()
) )
with InsertionPoint(sequence.body): with InsertionPoint(sequence.body):
Show All 22 Lines