This is an archive of the discontinued LLVM Phabricator instance.

[DWARFLinkerParallel] Switch to xxh3_64bits
ClosedPublic

Authored by MaskRay on Jul 19 2023, 12:09 AM.

Details

Summary

xxh3 is substantially faster than xxh64.
For lld .debug_str there is substantial speedup (D154813).

@avl reports that it is around 1-2% improvement for different number of input sets and for different threads configuration.

Diff Detail

Event Timeline

MaskRay created this revision.Jul 19 2023, 12:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2023, 12:09 AM
MaskRay requested review of this revision.Jul 19 2023, 12:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2023, 12:09 AM
avl added a comment.Jul 19 2023, 9:12 AM

I checked the performance impact on x86_64 ubuntu using utility from D132548 - it looks like, it is around 1-2% improvement for different number of input sets and for different threads configuration.

avl accepted this revision.Jul 19 2023, 9:13 AM

LGTM

This revision is now accepted and ready to land.Jul 19 2023, 9:13 AM

I checked the performance impact on x86_64 ubuntu using utility from D132548 - it looks like, it is around 1-2% improvement for different number of input sets and for different threads configuration.

Thank you for checking!

MaskRay edited the summary of this revision. (Show Details)Jul 19 2023, 9:53 AM
This revision was automatically updated to reflect the committed changes.