This is an archive of the discontinued LLVM Phabricator instance.

llvm/test/Transforms/MemCpyOpt/stack-move.ll
385	immediate
417	Is this call needed to reproduce the crash?
419	fastcc and byval here look unnecessary (byval can be replaced by nocapture).
423	I don't think this extra br is needed, you can directly resume.

This revision is now accepted and ready to land.Jul 18 2023, 5:34 AM

slanterns added a subscriber: slanterns.Jul 18 2023, 6:42 AM

Harbormaster completed remote builds in B246140: Diff 541418.Jul 18 2023, 7:50 AM

apply feedback

@nikic Thank you for the review!

llvm/test/Transforms/MemCpyOpt/stack-move.ll
417	No, just some copy source residue noise! Thanks!
423	Right!

khei4 marked 3 inline comments as done.Jul 19 2023, 2:08 AM

This revision was landed with ongoing or failed builds.Jul 19 2023, 2:26 AM

Closed by commit rGbdc9a6b1e9ee: [MemCpyOpt] add terminator user test for D153453(NFC) (authored by khei4). · Explain Why

This revision was automatically updated to reflect the committed changes.

khei4 added a commit: rGbdc9a6b1e9ee: [MemCpyOpt] add terminator user test for D153453(NFC).

Harbormaster completed remote builds in B246465: Diff 541902.Jul 19 2023, 4:23 AM

Revision Contents

Path

Size

llvm/

test/

Transforms/

MemCpyOpt/

stack-move.ll

40 lines

Diff 541910

llvm/test/Transforms/MemCpyOpt/stack-move.ll

Show First 20 Lines • Show All 375 Lines • ▼ Show 20 Lines	;

%1 = call i32 @use_writeonly(ptr nocapture %src)		%1 = call i32 @use_writeonly(ptr nocapture %src)
%2 = call i32 @use_writeonly(ptr nocapture %dest)		%2 = call i32 @use_writeonly(ptr nocapture %dest)
call void @llvm.lifetime.end.p0(i64 12, ptr nocapture %src)		call void @llvm.lifetime.end.p0(i64 12, ptr nocapture %src)
call void @llvm.lifetime.end.p0(i64 12, ptr nocapture %dest)		call void @llvm.lifetime.end.p0(i64 12, ptr nocapture %dest)
ret void		ret void
}		}

		; TODO: if the last user is terminator, we won't insert lifetime.end.
		; For multi-bb patch, we will insert it for next immediate post dominator block.
		nikicUnsubmitted Done Reply Inline Actions immediate nikic: immediate
		define void @terminator_lastuse() personality i32 0 {
		; CHECK-LABEL: define void @terminator_lastuse() personality i32 0 {
		; CHECK-NEXT: [[SRC:%.]] = alloca [[STRUCT_FOO:%.]], align 4
		; CHECK-NEXT: [[DEST:%.*]] = alloca [[STRUCT_FOO]], align 4
		; CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 12, ptr nocapture [[SRC]])
		; CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 12, ptr nocapture [[DEST]])
		; CHECK-NEXT: store [[STRUCT_FOO]] { i32 10, i32 20, i32 30 }, ptr [[SRC]], align 4
		; CHECK-NEXT: [[TMP1:%.*]] = call i32 @use_nocapture(ptr nocapture [[SRC]])
		; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 4 [[DEST]], ptr align 4 [[SRC]], i64 12, i1 false)
		; CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 12, ptr [[SRC]])
		; CHECK-NEXT: [[RV:%.*]] = invoke i32 @use_nocapture(ptr [[DEST]])
		; CHECK-NEXT: to label [[SUC:%.]] unwind label [[UNW:%.]]
		; CHECK: unw:
		; CHECK-NEXT: [[LP:%.*]] = landingpad i32
		; CHECK-NEXT: cleanup
		; CHECK-NEXT: resume i32 0
		; CHECK: suc:
		; CHECK-NEXT: ret void
		;
		%src = alloca %struct.Foo, align 4
		%dest = alloca %struct.Foo, align 4
		call void @llvm.lifetime.start.p0(i64 12, ptr nocapture %src)
		call void @llvm.lifetime.start.p0(i64 12, ptr nocapture %dest)
		store %struct.Foo { i32 10, i32 20, i32 30 }, ptr %src
		%1 = call i32 @use_nocapture(ptr nocapture %src)

		call void @llvm.memcpy.p0.p0.i64(ptr align 4 %dest, ptr align 4 %src, i64 12, i1 false)

		call void @llvm.lifetime.end.p0(i64 12, ptr %src)
		%rv = invoke i32 @use_nocapture(ptr %dest)
		to label %suc unwind label %unw
		unw:
		nikicUnsubmitted Done Reply Inline Actions Is this call needed to reproduce the crash? nikic: Is this call needed to reproduce the crash?
		khei4AuthorUnsubmitted Done Reply Inline Actions No, just some copy source residue noise! Thanks! khei4: No, just some copy source residue noise! Thanks!
		%lp = landingpad i32 cleanup
		resume i32 0
		nikicUnsubmitted Done Reply Inline Actions fastcc and byval here look unnecessary (byval can be replaced by nocapture). nikic: fastcc and byval here look unnecessary (byval can be replaced by nocapture).
		suc:
		ret void
		}

		nikicUnsubmitted Done Reply Inline Actions I don't think this extra br is needed, you can directly resume. nikic: I don't think this extra br is needed, you can directly resume.
		khei4AuthorUnsubmitted Done Reply Inline Actions Right! khei4: Right!
; TODO: merge allocas for bb-separated, but logically straight		; TODO: merge allocas for bb-separated, but logically straight
define void @multi_bb_memcpy(i1 %b) {		define void @multi_bb_memcpy(i1 %b) {
; CHECK-LABEL: define void @multi_bb_memcpy		; CHECK-LABEL: define void @multi_bb_memcpy
; CHECK-SAME: (i1 [[B:%.*]]) {		; CHECK-SAME: (i1 [[B:%.*]]) {
; CHECK-NEXT: [[SRC:%.*]] = alloca i32, align 4		; CHECK-NEXT: [[SRC:%.*]] = alloca i32, align 4
; CHECK-NEXT: [[DEST:%.*]] = alloca i32, align 4		; CHECK-NEXT: [[DEST:%.*]] = alloca i32, align 4
; CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 4, ptr nocapture [[SRC]])		; CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 4, ptr nocapture [[SRC]])
; CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 4, ptr nocapture [[DEST]])		; CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 4, ptr nocapture [[DEST]])
▲ Show 20 Lines • Show All 706 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[MemCpyOpt] add terminator user test for D153453(NFC)ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 541910

llvm/test/Transforms/MemCpyOpt/stack-move.ll

[MemCpyOpt] add terminator user test for D153453(NFC)
ClosedPublic