This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Link to fewer MSVC CRT libraries
ClosedPublic

Authored by mstorsjo on Jul 18 2023, 12:42 AM.

Details

Reviewers
Mordante
jyknight
andrewng
Group Reviewers
Restricted Project
Commits
rG7506cb3c926a: [libcxx] Link to fewer MSVC CRT libraries
Summary

The library msvcrt.lib pulls in ucrt.lib and vcruntime.lib anyway,
there's no need to manually link against the individual dependencies.

This matches how the tests link against libraries - they only link
against msvcrt and msvcprt, not directly against ucrt and vcruntime.

Diff Detail

Event Timeline

mstorsjo created this revision.Jul 18 2023, 12:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 12:42 AM
mstorsjo requested review of this revision.Jul 18 2023, 12:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 12:42 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision.Jul 18 2023, 8:42 AM

Since the CI is happy, LGTM!

This revision is now accepted and ready to land.Jul 18 2023, 8:42 AM
This revision was automatically updated to reflect the committed changes.