[mlir][transform][python] Add extended ApplyPatternsOp.

[ingomueller-net]

Summary

This patch adds a mixin for ApplyPatternsOp to _transform_ops_ext.py
with syntactic sugar for construction such ops. Curiously, the op did
not have any constructors yet, probably because its tablegen definition
said to skip the default builders. The new constructor is thus quite
straightforward. The commit also adds a refined region property which
returns the first block of the single region.

[ingomueller-net]

Adding tests and rephrasing commit message.

[ftynse]

Nit: can we retitle the commit to explicitly refer to python bindings? Currently it reads as if it were actually adding an op.

mlir/python/mlir/dialects/_transform_ops_ext.py

54

It is confusing that region property returns a block rather than a region. Can we give it a different name?

[ingomueller-net]

Address @ftynse's comment:

• Change commit title.

[ingomueller-net]

mlir/python/mlir/dialects/_transform_ops_ext.py

54

Ha, I had overlooked this comment until now.

Yes, I agree. Relatedly, the name region in the td file isn't particularly meaningful. Maybe that should be changed? Maybe body or patterns? (Then the name of this property would be the same.)

[ftynse]

mlir/python/mlir/dialects/_transform_ops_ext.py

54

Can we make it consistent with what's in ODS?

[ingomueller-net]

mlir/python/mlir/dialects/_transform_ops_ext.py

54

That's the current state: it is called "region" in ODS. If we want a different name *and* consistency, we need to change ODS.

[ingomueller-net]

mlir/python/mlir/dialects/_transform_ops_ext.py

54

In case it isn't clear: I can't address both of your requests at the same time, @ftynse, rename region and make it consistent with ODS, because it is called region in ODS. My preferred solution is to rename the region to patterns in ODS and do the same here. Does that work for you?

[ftynse]

mlir/python/mlir/dialects/_transform_ops_ext.py

54

Works for me, thanks!

[ingomueller-net]

• Rebase on top of https://reviews.llvm.org/D155810.
• Follow its renamig from region to patterns.
• Rename test label to make them prefix-free.

mlir/python/mlir/dialects/_transform_ops_ext.py

def __init__(
       loc=None,
       ip=None,
   ):
     super().__init__(
         result_type, _get_op_result_or_value(target), loc=loc, ip=ip
     )
 
 
+class ApplyPatternsOp:
+
+  def __init__(
+      self,
+      target: Union[Operation, Value, OpView],
+      *,
+      loc=None,
+      ip=None,
+  ):
+    operands = []
+    operands.append(_get_op_result_or_value(target))
+    super().__init__(
+        self.build_generic(attributes={},
+                           results=[],
+                           operands=operands,
+                           successors=None,
+                           regions=None,
+                           loc=loc,
+                           ip=ip))
+    self.regions[0].blocks.append()
+
+  @property
+  def patterns(self) -> Block:
+    return self.regions[0].blocks[0]
+
+
 class testGetParentOp:
 
   def __init__(
       self,
       result_type: Type,
       target: Union[Operation, Value],
       *,
       isolated_from_above: bool = False,

mlir/test/python/dialects/transform.py

with InsertionPoint(sequence.body):
         transform.YieldOp()
     # CHECK-LABEL: TEST: testMergeHandlesOp
     # CHECK: transform.sequence
     # CHECK: ^{{.*}}(%[[ARG1:.+]]: !transform.any_op):
     # CHECK:   = merge_handles %[[ARG1]]
 
 
 @run
+def testApplyPatternsOpCompact():
+  sequence = transform.SequenceOp(
+      transform.FailurePropagationMode.PROPAGATE, [], transform.AnyOpType.get()
+  )
+  with InsertionPoint(sequence.body):
+    with InsertionPoint(transform.ApplyPatternsOp(sequence.bodyTarget).patterns):
+      transform.ApplyCanonicalizationPatternsOp()
+    transform.YieldOp()
+    # CHECK-LABEL: TEST: testApplyPatternsOpCompact
+    # CHECK: apply_patterns to
+    # CHECK: transform.apply_patterns.canonicalization
+    # CHECK: !transform.any_op
+
+
+@run
+def testApplyPatternsOpWithType():
+  sequence = transform.SequenceOp(
+      transform.FailurePropagationMode.PROPAGATE, [],
+      transform.OperationType.get('test.dummy')
+  )
+  with InsertionPoint(sequence.body):
+    with InsertionPoint(transform.ApplyPatternsOp(sequence.bodyTarget).patterns):
+      transform.ApplyCanonicalizationPatternsOp()
+    transform.YieldOp()
+    # CHECK-LABEL: TEST: testApplyPatternsOp
+    # CHECK: apply_patterns to
+    # CHECK: transform.apply_patterns.canonicalization
+    # CHECK: !transform.op<"test.dummy">
+
+
+@run
 def testReplicateOp():
     with_pdl = transform_pdl.WithPDLPatternsOp(transform.AnyOpType.get())
     with InsertionPoint(with_pdl.body):
         sequence = transform.SequenceOp(
             transform.FailurePropagationMode.PROPAGATE, [], with_pdl.bodyTarget
         )
         with InsertionPoint(sequence.body):
             m1 = transform_pdl.PDLMatchOp(