This is an archive of the discontinued LLVM Phabricator instance.

[Bindings] Remove duplicate declaration
Needs ReviewPublic

Authored by tamird on Jul 16 2023, 5:24 AM.

Details

Summary

a27771b62f2f8c399ed8fac124810a273226d5d5 moved
LLVMAddInstructionCombiningPass but neglected to remove the previous
declaration, resulting in a duplicate.

This is harmless in C, but can cause problems downstream if e.g. code is
generated from these bindings.

This function is removed on master, so this commit is made against
release/16.x.

Diff Detail

Event Timeline

tamird created this revision.Jul 16 2023, 5:24 AM
Herald added a project: Restricted Project. · View Herald Transcript
tamird requested review of this revision.Jul 16 2023, 5:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 16 2023, 5:24 AM

SGTM, though I don't quite understand the "This function is removed on master, so this commit is made against release/16.x." comment?

Oh, the function's entirely removed, but you need a fix in 16.x - @tstellar are you still managing point releases, or can point this patch to who is? I don't know what the protocol is for patching the releases/approving release-branch-only patches.

We aren't accepting release/16.x patches any more.