This is an archive of the discontinued LLVM Phabricator instance.

[ubsan] Disable sigaction.cpp on x86_64 w/ ubsan-tsan
AbandonedPublic

Authored by Caslyn on Jul 13 2023, 4:57 PM.

Details

Reviewers
dvyukov

Diff Detail

Event Timeline

Caslyn created this revision.Jul 13 2023, 4:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2023, 4:57 PM
Caslyn updated this revision to Diff 540698.Jul 15 2023, 9:33 AM

Test excluding x86_64

Caslyn updated this revision to Diff 540701.Jul 15 2023, 9:59 AM

Restore RUN directive

Caslyn published this revision for review.Jul 15 2023, 12:22 PM
Caslyn added a subscriber: dvyukov.

@dvyukov - I think this could resolve the remaining error we're seeing on Fuchsia linux-x86_64 builds like this one: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8775481122257091553/overview

This patch will expect the the UBSan-ThreadSanitizer-x86_64 :: TestCases/Misc/Linux/sigaction.cpp to fail as it does on that build. I think the fuchsia-x86_64-linux would have caught this, but it appears out of commission.

Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2023, 12:22 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Caslyn retitled this revision from [WIP] UBSan-ThreadSanitizer-aarch64 compat to [ubsan] Disable sigaction.cpp on x86_64 w/ ubsan-tsan.Jul 15 2023, 12:26 PM

It only fails on Fuchsia Linux, right? (passed for me on normal Linux)
If so, please exclude on Fuchsia Linux.

Caslyn abandoned this revision.Jul 18 2023, 3:36 PM
Caslyn added a subscriber: mysterymath.

Abandoning this attempt - and agree that it's too heavy handed. @mysterymath has taken the lead on debugging.