This is an archive of the discontinued LLVM Phabricator instance.

Bump up MAX_SUBTARGET_FEATURES
ClosedPublic

Authored by weimingz on Dec 14 2015, 6:21 PM.

Details

Summary

Currently, ARMGenSubtargetInfo (from ARM.td) is reaching the limit of 96:

enum : uint64_t {
     ...
     XScale = 95
};

We need to bump the maximum value up to accommodate future changes and/or customized subtarget definitions.

Diff Detail

Repository
rL LLVM

Event Timeline

weimingz updated this revision to Diff 42809.Dec 14 2015, 6:21 PM
weimingz retitled this revision from to Bump up MAX_SUBTARGET_FEATURES.
weimingz updated this object.
weimingz set the repository for this revision to rL LLVM.
weimingz added a subscriber: llvm-commits.
t.p.northover edited edge metadata.Dec 14 2015, 6:32 PM

104 is a bit of an odd choice (not even an extra byte). I'd just bump it to 128, and hope we can leave it there for a while.

Other than that, sure.

Sorry, it is an extra byte (I've never been one for mental arithmetic: "is a natural number" has always sufficed). I'd still go for 128 though.

weimingz updated this revision to Diff 42811.Dec 14 2015, 6:35 PM
weimingz edited edge metadata.
weimingz removed rL LLVM as the repository for this revision.

Agree. 128 makes more sense.

t.p.northover accepted this revision.Dec 14 2015, 6:46 PM
t.p.northover edited edge metadata.

Go for it!

Tim.

This revision is now accepted and ready to land.Dec 14 2015, 6:46 PM
weimingz closed this revision.Dec 14 2015, 8:45 PM