This is an archive of the discontinued LLVM Phabricator instance.

[mlir][cmake] Comment out redundant static assert regarding VarInfo struct
ClosedPublic

Authored by amirBish on Jul 11 2023, 3:31 AM.

Diff Detail

Event Timeline

amirBish created this revision.Jul 11 2023, 3:31 AM
Herald added a project: Restricted Project. · View Herald Transcript
amirBish requested review of this revision.Jul 11 2023, 3:31 AM
amirBish added a comment.EditedJul 11 2023, 3:57 AM

@aartbik as a result of this issue https://github.com/llvm/llvm-project/issues/63773 , I've uploaded this revision which comments out the static_assert() as you've suggested

aartbik accepted this revision.Jul 11 2023, 8:44 AM
aartbik added inline comments.
mlir/lib/Dialect/SparseTensor/IR/Detail/Var.h
389–390

can you add a TODO indicator, so we remember to bring it back

This revision is now accepted and ready to land.Jul 11 2023, 8:44 AM
amirBish updated this revision to Diff 539215.Jul 11 2023, 11:39 AM

TODO indicator for the comment

amirBish marked an inline comment as done.Jul 11 2023, 11:39 AM

I'll land this, gcc-7 build is broken without this.