This is an archive of the discontinued LLVM Phabricator instance.

[ConstantHoisting] remove a LLVM_DEBUG statement
ClosedPublic

Authored by nickdesaulniers on Jul 10 2023, 3:48 PM.

Details

Summary

There is no need to print the entire function after a transform via
LLVM_DEBUG statements. These can be emulated via:
$ llc -print-after=consthoist -filter-print-funcs=<function name>

Otherwise, this makes the output of
$ llc -debug-only=consthoist
too verbose.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: hiraditya. · View Herald Transcript
nickdesaulniers requested review of this revision.Jul 10 2023, 3:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2023, 3:48 PM
MaskRay accepted this revision.Jul 10 2023, 4:27 PM

I agree, we should just use regular dumping options.

This revision is now accepted and ready to land.Jul 10 2023, 4:27 PM
This revision was landed with ongoing or failed builds.Jul 11 2023, 9:30 AM
This revision was automatically updated to reflect the committed changes.