This is an archive of the discontinued LLVM Phabricator instance.

[clang][AST] Propagate the contains-errors bit to DeclRefExpr from VarDecl's initializer.
ClosedPublic

Authored by hokein on Jul 10 2023, 9:35 AM.

Diff Detail

Event Timeline

hokein created this revision.Jul 10 2023, 9:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2023, 9:35 AM
hokein requested review of this revision.Jul 10 2023, 9:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2023, 9:35 AM
aaron.ballman accepted this revision.Jul 10 2023, 9:49 AM

LGTM, but please be sure to add a release note (and the newline at the end of the test file). Thank you for the fix!

clang/test/AST/ast-dump-recovery.c
151

Please add a newline to the end of the file. :-)

This revision is now accepted and ready to land.Jul 10 2023, 9:49 AM
shafik added inline comments.Jul 10 2023, 3:27 PM
clang/lib/AST/ComputeDependence.cpp
461

computeDependence does not feel particularly well organized, it is not clear to me how correct it is :-(

532

It feels like we could fold this under the if (const Expr *Init = Var->getAnyInitializer(); Init above and not duplicate code.

sammccall accepted this revision.Jul 10 2023, 9:35 PM
hokein updated this revision to Diff 538929.Jul 11 2023, 12:13 AM
hokein marked 2 inline comments as done.

address comments and add release note.

This revision was landed with ongoing or failed builds.Jul 11 2023, 12:30 AM
This revision was automatically updated to reflect the committed changes.