There are discussions about different ways of implementing stop_token to make it more performant
mark stop_token as experimental to allow us to change the design before it is shipped
Details
- Reviewers
huixie90 ldionne - Group Reviewers
Restricted Project - Commits
- rG477f6bc407db: [libc++] Make `stop_token` experimental
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
libcxx/include/__stop_token/stop_callback.h | ||
---|---|---|
23 | Let's instead add something like this to __config: # if !defined(_LIBCPP_ENABLE_EXPERIMENTAL) && !defined(_LIBCPP_BUILDING_LIBRARY) # define _LIBCPP_HAS_NO_INCOMPLETE_STOP_TOKEN # endif | |
libcxx/test/std/thread/thread.stoptoken/nostopstate/cons.default.pass.cpp | ||
10 | Here let's introduce a specific Lit feature for it. |
I mainly glossed over the the patch.
libcxx/test/std/thread/thread.stoptoken/nostopstate/cons.default.pass.cpp | ||
---|---|---|
10 | Please also update libcxx/test/libcxx/experimental/fexperimental-library.compile.pass.cpp |
libcxx/include/__stop_token/stop_callback.h | ||
---|---|---|
15 | Also let's tweak the release note. |
libcxx/include/__stop_token/stop_callback.h | ||
---|---|---|
15 | I already made changes in my draft update for the release notes ;-) |
libcxx/include/__stop_token/stop_callback.h | ||
---|---|---|
15 | Oh, nice, thanks for having a review with updates to the release notes. This comment was actually saying that we should update the release notes to account for the fact that this is now experimental, however I realized that we didn't add stop_token to the release notes at all, so that's moot. But if you mention stop_token in your release notes update, let's mention it as being experimental. |
libcxx/include/__stop_token/stop_callback.h | ||
---|---|---|
15 | That's what I already did ;-) |
CI failure is a fluke, merging.
libcxx/include/__stop_token/stop_callback.h | ||
---|---|---|
15 | Great, thanks! |
Also let's tweak the release note.