[MLIR][Tosa] TosaToTensor: create valid reshapes

[mgehre-amd]

Summary

The pattern would create reshape ops without a newShape attr.
This fails the verifier (which can be seen in the debug output;
but curiously doesn't abort compilation),
and can cause crashes in other code that expect to see valid
reshape ops, like ReshapeOp::fold.

The effects cannot be seen in the the test case of the pass because the results of this pattern
are further transformed by other patterns of this pass.

[eric-k256]

Looks good to me. I'm also not sure why the existing version does not fail.

mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp

if (!findIntermediateShape(resultTy.getShape(), operandTy.getShape(),
           reshape, "tosa.reshape Cannot identify an intermediate shape between "
                    "the given two shapes");
     }
 
     Value collapse = rewriter.create<tosa::ReshapeOp>(
         reshape.getLoc(),
         RankedTensorType::get(intermediateShape,
                               reshape.getType().getElementType()),
-        adaptor.getInput1());
-    Value expand =
-        rewriter.create<tosa::ReshapeOp>(reshape.getLoc(), resultTy, collapse);
+        adaptor.getInput1(), rewriter.getDenseI64ArrayAttr(intermediateShape));
+    Value expand = rewriter.create<tosa::ReshapeOp>(
+        reshape.getLoc(), resultTy, collapse,
+        rewriter.getDenseI64ArrayAttr(resultTy.getShape()));
     rewriter.replaceOp(reshape, expand);
 
     return success();
   }
 };
 
 class SliceConverter : public OpConversionPattern<tosa::SliceOp> {
 public: