This is an archive of the discontinued LLVM Phabricator instance.

[emacs] Highlight 'zeroext' and 'signext' keyword as an attribute
ClosedPublic

Authored by goldstein.w.n on Jul 6 2023, 12:06 AM.

Details

Summary

Seems natural to highlight 'zeroext' and 'signext' along with other attributes
like 'nonnull', 'noundef', etc..

Diff Detail

Event Timeline

goldstein.w.n created this revision.Jul 6 2023, 12:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2023, 12:06 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
goldstein.w.n requested review of this revision.Jul 6 2023, 12:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2023, 12:06 AM
nikic added a comment.Jul 6 2023, 12:08 AM

Also add signext?

goldstein.w.n retitled this revision from [emacs] Highlight 'zeroext' keyword as an attribute to [emacs] Highlight 'zeroext' and 'signext' keyword as an attribute.Jul 6 2023, 9:45 AM

Also add signext?

Done (just tend to add as I notice).

Out of curiosity, do you use emacs or are you just a kind soul to review this?

nikic accepted this revision.Jul 6 2023, 10:06 AM

LGTM, but the patch description refers to the wrong attributes.

Out of curiosity, do you use emacs or are you just a kind soul to review this?

Nope, I use vim :)

llvm/utils/emacs/llvm-mode.el
29–30

The attributes here are (mostly) sorted, so maybe but signext next to shadowcallstack?

This revision is now accepted and ready to land.Jul 6 2023, 10:06 AM
goldstein.w.n edited the summary of this revision. (Show Details)Jul 6 2023, 10:50 AM
This revision was landed with ongoing or failed builds.Jul 6 2023, 12:47 PM
This revision was automatically updated to reflect the committed changes.