Seems natural to highlight 'zeroext' and 'signext' along with other attributes
like 'nonnull', 'noundef', etc..
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Done (just tend to add as I notice).
Out of curiosity, do you use emacs or are you just a kind soul to review this?
Comment Actions
LGTM, but the patch description refers to the wrong attributes.
Out of curiosity, do you use emacs or are you just a kind soul to review this?
Nope, I use vim :)
llvm/utils/emacs/llvm-mode.el | ||
---|---|---|
29–30 | The attributes here are (mostly) sorted, so maybe but signext next to shadowcallstack? |
The attributes here are (mostly) sorted, so maybe but signext next to shadowcallstack?