[UTC] Fix git URL regex

[hnrklssn]

Summary

The previous git URL regex only matched SSH urls, starting with 'git@'.
If the repo was cloned using a https URL it would not match.

rdar://105239218

[hnrklssn]

This patch has already been landed as 6d64faf. This is my first time requesting a post-commit review (since I broke the buildbot and the fix was trivial), so please let me know if I missed something in that process.

[nikic]

llvm/utils/UpdateTestChecks/common.py

1576

I think this needs to be more permissive than that. E.g. my installed clang version is clang version 15.0.7 (Fedora 15.0.7-2.fc37) and my development version is just clang version 17.0.0 because I have git detection disabled. (If this is the same as clang -v.)

[hnrklssn]

llvm/utils/UpdateTestChecks/common.py

1576

Do you think (\w+ version )[\d.]+( \([\w.:/@ -]+\))? would work well, or should we go all out with (\w+ version )[\d.]+.*?

[hnrklssn]

llvm/utils/UpdateTestChecks/common.py

1576

Looking into the various possible custom version outputs, I think this is a reasonable approach that works well for all outputs that don't contain the " character: (\w+ version )[\d.]+.*(?=\")

[hnrklssn]

Handle lack of git URL, as well as custom additions to the version message.

[nikic]

Superseded by D154520, I believe.

This is my first time requesting a post-commit review (since I broke the buildbot and the fix was trivial), so please let me know if I missed something in that process.

Generally, post-commit review means that someone sees your commit and leaves a comment on it -- it's not necessary to submit an actual review for it after the fact.

llvm/utils/UpdateTestChecks/common.py

return [
         line
         for line in global_val_lines
         if extract(line, nameless_value)[0] in transitively_visible
     ]
 
 
 # The capture group is kept as is, followed by a {{.*}} glob
 METADATA_FILTERS = [
-    r"(\w+ version )[\d.]+ \([\w.:/@-]+\.git \w+\)",
+    r"(\w+ version )[\d.]+.*(?=\")",
     r'(!DIFile\(filename: ".+", directory: )".+"',
 ]
 METADATA_FILTERS_RE = [re.compile(s) for s in METADATA_FILTERS]
 
 
 def filter_unstable_metadata(line):
     for f in METADATA_FILTERS_RE:
         line = f.sub(r"\1{{.*}}", line)