I decided not to wait for D149088 because it was taking a long time.
The capture group in the regexp was changed to non-capturing. It
doesn't need to be captured.
Differential D154467
[clang-format] Add Verilog suffixes to the scripts sstwcw on Jul 4 2023, 4:50 PM. Authored by
Details I decided not to wait for D149088 because it was taking a long time. The capture group in the regexp was changed to non-capturing. It
Diff Detail
Event TimelineComment Actions NOTE: Clang-Format Team Automated Review Comment
It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes have a unit test (unless this is an NFC or refactoring, adding documentation etc..) Add your unit tests in clang/unittests/Format and you can build with ninja FormatTests. We recommend using the verifyFormat(xxx) format of unit tests rather than EXPECT_EQ as this will ensure you change is tolerant to random whitespace changes (see FormatTest.cpp as an example) For situations where your change is altering the TokenAnnotator.cpp which can happen if you are trying to improve the annotation phase to ensure we are correctly identifying the type of a token, please add a token annotator test in TokenAnnotatorTest.cpp This comment was removed by MyDeveloperDay. |