This is an archive of the discontinued LLVM Phabricator instance.

[LoongArch] Add definition for LASX instructions
ClosedPublic

Authored by wangleiat on Jun 30 2023, 2:48 AM.

Details

Summary

This patch adds the definition of the LASX instructions, providing
support only for assembly and disassembly, similar to D154183.

Depends on D154183

Diff Detail

Event Timeline

wangleiat created this revision.Jun 30 2023, 2:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2023, 2:48 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
wangleiat requested review of this revision.Jun 30 2023, 2:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2023, 2:48 AM
xen0n added a comment.Jun 30 2023, 2:55 AM

One minor nit. Otherwise LGTM from a cursory look, thanks!

llvm/lib/Target/LoongArch/LoongArchLASXInstrInfo.td
10

typo: "Advanced"

wangleiat marked an inline comment as done.Jun 30 2023, 3:08 AM
wangleiat added inline comments.
llvm/lib/Target/LoongArch/LoongArchLASXInstrInfo.td
10

typo: "Advanced"

Thanks, done.

wangleiat updated this revision to Diff 536654.Jul 2 2023, 8:35 PM
wangleiat marked an inline comment as done.
  1. Add register definition, and fix the old interface parameters.
  2. Specify instruction properties.
SixWeining accepted this revision.Jul 6 2023, 4:30 AM
This revision is now accepted and ready to land.Jul 6 2023, 4:30 AM
This revision was landed with ongoing or failed builds.Jul 6 2023, 8:23 PM
This revision was automatically updated to reflect the committed changes.