[libc++] Remove support for .fail.cpp tests

[ldionne]

Summary

We want to move away from those tests and towards explicit .verify.cpp
tests, since those have a simpler model.

[ldionne]

Re-upload after setting parent revision for CI.

[Mordante]

Thanks for the cleanup! LGTM when the CI passes; it seems to have skipped this patch.

[ldionne]

Rebase onto main to poke CI.

libcxx/test/libcxx/selftest/fail.cpp/compile-failure.fail.cpp

-//===----------------------------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-// Make sure the test passes if we don't have clang-verify support and
-// the test fails to compile.
-
-// UNSUPPORTED: verify-support
-
-struct Foo { };
-typedef Foo::x x;

libcxx/test/libcxx/selftest/fail.cpp/compile-success.fail.cpp

-//===----------------------------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-// XFAIL: *
-
-// Make sure the test DOES NOT pass if we don't have clang-verify support and
-// the test compiles successfully.
-
-// UNSUPPORTED: verify-support
-
-int main(int, char**) { return 0; }

libcxx/test/libcxx/selftest/fail.cpp/no-diagnostics-unmarked.fail.cpp

-//===----------------------------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-// REQUIRES: verify-support
-
-// XFAIL: *
-
-// Make sure the test DOES NOT pass if there are no diagnostics, but we didn't
-// use the 'expected-no-diagnostics' markup.
-//
-// Note: For the purpose of this test, make sure the file would otherwise
-//       compile to make sure we really fail due to a lack of markup.
-
-int main(int, char**) { return 0; }

libcxx/test/libcxx/selftest/fail.cpp/no-diagnostics.fail.cpp

-//===----------------------------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-// REQUIRES: verify-support
-
-// Make sure the test passes if we expected no diagnostics and included
-// the markup.
-
-// expected-no-diagnostics

libcxx/test/libcxx/selftest/fail.cpp/right-diagnostic.fail.cpp

-//===----------------------------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-// REQUIRES: verify-support
-
-// Make sure the test passes if it fails at compile-time with the expected
-// diagnostic.
-
-struct Foo { };
-typedef Foo::x x; // expected-error{{no type named 'x' in 'Foo'}}
-
-int main(int, char**) { return 0; }

libcxx/test/libcxx/selftest/fail.cpp/wrong-diagnostic.fail.cpp

-//===----------------------------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-// REQUIRES: verify-support
-
-// XFAIL: *
-
-// Make sure the test DOES NOT pass if the expected diagnostic is wrong.
-
-struct Foo { };
-typedef Foo::x x; // expected-error{{this is not found in the errors}}
-
-int main(int, char**) { return 0; }

libcxx/utils/libcxx/test/format.py

FOO.gen.<anything>      - A .sh test that generates one or more Lit tests on the
                               useful for testing repetitive properties in the library.
                               Be careful not to abuse this since this is not a replacement
                               for usual code reuse techniques.
 
     FOO.verify.cpp          - Compiles with clang-verify. This type of test is
                               automatically marked as UNSUPPORTED if the compiler
                               does not support Clang-verify.
 
-    FOO.fail.cpp            - Compiled with clang-verify if clang-verify is
-                              supported, and equivalent to a .compile.fail.cpp
-                              test otherwise. This is supported only for backwards
-                              compatibility with the test suite.
-
 
     Substitution requirements
     ===============================
     The test format operates by assuming that each test's configuration provides
     the following substitutions, which it will reuse in the shell scripts it
     constructs:
         %{cxx}           - A command that can be used to invoke the compiler
         %{compile_flags} - Flags to use when compiling a test case
def execute(self, test, litConfig):
         # Make sure to check these ones last, since they will match other
         # suffixes above too.
         elif filename.endswith(".pass.cpp") or filename.endswith(".pass.mm"):
             steps = [
                 "%dbg(COMPILED WITH) %{cxx} %s %{flags} %{compile_flags} %{link_flags} -o %t.exe",
                 "%dbg(EXECUTED AS) %{exec} %t.exe",
             ]
             return self._executeShTest(test, litConfig, steps)
-        # This is like a .verify.cpp test when clang-verify is supported,
-        # otherwise it's like a .compile.fail.cpp test. This is only provided
-        # for backwards compatibility with the test suite.
-        elif filename.endswith(".fail.cpp"):
-            if supportsVerify:
-                steps = [
-                    "%dbg(COMPILED WITH) %{{cxx}} %s %{{flags}} %{{compile_flags}} -fsyntax-only -Wno-error {}".format(
-                        VERIFY_FLAGS
-                    )
-                ]
-            else:
-                steps = [
-                    "%dbg(COMPILED WITH) ! %{cxx} %s %{flags} %{compile_flags} -fsyntax-only"
-                ]
-            return self._executeShTest(test, litConfig, steps)
         else:
             return lit.Test.Result(
                 lit.Test.UNRESOLVED, "Unknown test suffix for '{}'".format(filename)
             )
 
     def _executeShTest(self, test, litConfig, steps):
         if test.config.unsupported:
             return lit.Test.Result(lit.Test.UNSUPPORTED, "Test is unsupported")