[libc++] Move all the remaining .fail.cpp tests to .verify.cpp

[ldionne]

Summary

I made sure they all had some expected-error output in them. Many of
these tests would be better implemented as a positive test using SFINAE,
but this is beyond the scope of this patch.

[ldionne]

Fix test that would be broken by a file renaming.

[ldionne]

libcxx/test/std/utilities/intseq/intseq.make/make_integer_seq.verify.cpp

12

This is one of the only two tests I actually had to change instead of just blindly renaming.

libcxx/test/std/utilities/intseq/intseq.make/make_integer_seq_fallback.verify.cpp

12

This is the second one. Everything else is just renaming.

[Mordante]

I only checked the called out tests. LGTM but I have a question.

libcxx/test/std/utilities/intseq/intseq.make/make_integer_seq.verify.cpp

27

Why is it safe to remove the !defined(_LIBCPP_TESTING_FALLBACK_MAKE_INTEGER_SEQUENCE) part?

[ldionne]

libcxx/test/std/utilities/intseq/intseq.make/make_integer_seq.verify.cpp

27

We used to only define it from the other sibling test, and then we'd #include the sources for this test. Now both tests are "standalone", i.e. they don't include each other so this test (which doesn't test the fallback) doesn't need to check for _LIBCPP_TESTING_FALLBACK_MAKE_INTEGER_SEQUENCE.

[ldionne]

Fix modular CI issue by using ADDITIONAL_COMPILE_FLAGS instead of #define in TU.

libcxx/test/std/utilities/intseq/intseq.make/make_integer_seq.verify.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // <utility>
 
 // template<class T, T N>
 //   using make_integer_sequence = integer_sequence<T, 0, 1, ..., N-1>;
 
 // UNSUPPORTED: c++03, c++11
 
 // This test hangs during recursive template instantiation with libstdc++
 // UNSUPPORTED: stdlib=libstdc++
 
 #include <utility>
-#include <type_traits>
-#include <cassert>
 
 #include "test_macros.h"
 
-int main(int, char**)
-{
-  typedef std::make_integer_sequence<int, -3> MakeSeqT;
 
-  // std::make_integer_sequence is implemented using a compiler builtin if available.
-  // this builtin has different diagnostic messages than the fallback implementation.
-#if TEST_HAS_BUILTIN(__make_integer_seq) && !defined(_LIBCPP_TESTING_FALLBACK_MAKE_INTEGER_SEQUENCE)
-  MakeSeqT i; // expected-error@*:* {{integer sequences must have non-negative sequence length}}
+#if TEST_HAS_BUILTIN(__make_integer_seq)
 #else
-  MakeSeqT i; // expected-error-re@*:* {{{{(static_assert|static assertion)}} failed{{.*}}std::make_integer_sequence must have a non-negative sequence length}}
 #endif
-
-  return 0;
-}

libcxx/test/std/utilities/intseq/intseq.make/make_integer_seq_fallback.verify.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // <utility>
 
 // template<class T, T N>
 //   using make_integer_sequence = integer_sequence<T, 0, 1, ..., N-1>;
 
 // UNSUPPORTED: c++03, c++11
 
 // This test hangs during recursive template instantiation with libstdc++
 // UNSUPPORTED: stdlib=libstdc++
 
-#define _LIBCPP_TESTING_FALLBACK_MAKE_INTEGER_SEQUENCE
-#include "make_integer_seq.fail.cpp"
+// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_TESTING_FALLBACK_MAKE_INTEGER_SEQUENCE
+
+#include <utility>
+
+typedef std::make_integer_sequence<int, -3> MakeSeqT;
+MakeSeqT i; // expected-error-re@*:* {{{{(static_assert|static assertion)}} failed{{.*}}std::make_integer_sequence must have a non-negative sequence length}}