I made sure they all had some expected-error output in them. Many of
these tests would be better implemented as a positive test using SFINAE,
but this is beyond the scope of this patch.
Details
- Reviewers
Mordante - Group Reviewers
Restricted Project - Commits
- rGb82dcb624e6b: [libc++] Move all the remaining .fail.cpp tests to .verify.cpp
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
libcxx/test/std/utilities/intseq/intseq.make/make_integer_seq.verify.cpp | ||
---|---|---|
12 | This is one of the only two tests I actually had to change instead of just blindly renaming. | |
libcxx/test/std/utilities/intseq/intseq.make/make_integer_seq_fallback.verify.cpp | ||
12 ↗ | (On Diff #535407) | This is the second one. Everything else is just renaming. |
I only checked the called out tests. LGTM but I have a question.
libcxx/test/std/utilities/intseq/intseq.make/make_integer_seq.verify.cpp | ||
---|---|---|
34 | Why is it safe to remove the !defined(_LIBCPP_TESTING_FALLBACK_MAKE_INTEGER_SEQUENCE) part? |
libcxx/test/std/utilities/intseq/intseq.make/make_integer_seq.verify.cpp | ||
---|---|---|
34 | We used to only define it from the other sibling test, and then we'd #include the sources for this test. Now both tests are "standalone", i.e. they don't include each other so this test (which doesn't test the fallback) doesn't need to check for _LIBCPP_TESTING_FALLBACK_MAKE_INTEGER_SEQUENCE. |
This is one of the only two tests I actually had to change instead of just blindly renaming.