This is an archive of the discontinued LLVM Phabricator instance.

Differential D153931

[Fuchsia] Enable libcxx filesystem on Windows build.
ClosedPublic

Authored by haowei on Jun 27 2023, 4:55 PM.

Details

Reviewers
phosek
Prabhuk
Commits
rGfa872aa221e2: [Fuchsia] Enable libcxx filesystem on Windows build.
Summary

This patch enables the libcxx filesystem when building runtimes for Windows.

Diff Detail

Event Timeline

haowei created this revision.Jun 27 2023, 4:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2023, 4:55 PM
Herald added a subscriber: abrachet. · View Herald Transcript
haowei requested review of this revision.Jun 27 2023, 4:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2023, 4:55 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
haowei updated this revision to Diff 535194.Jun 27 2023, 4:57 PM
phosek accepted this revision.Jun 27 2023, 4:57 PM

LGTM

This revision is now accepted and ready to land.Jun 27 2023, 4:57 PM
This revision was landed with ongoing or failed builds.Jun 27 2023, 4:58 PM
Closed by commit rGfa872aa221e2: [Fuchsia] Enable libcxx filesystem on Windows build. (authored by haowei). · Explain Why
This revision was automatically updated to reflect the committed changes.
haowei added a commit: rGfa872aa221e2: [Fuchsia] Enable libcxx filesystem on Windows build..
Harbormaster completed remote builds in B241654: Diff 535194.Jun 27 2023, 6:58 PM
phosek mentioned this in rGe9fb7d6972b9: [Fuchsia] Enable libcxx filesystem on Windows for stage 1 build.Jun 27 2023, 10:43 PM

Revision Contents

PathSize
clang/
cmake/
caches/
1 line

Diff 535195

clang/cmake/caches/Fuchsia-stage2.cmake

Show First 20 Lines • Show All 113 Lines • ▼ Show 20 Linesif(WIN32 OR LLVM_WINSYSROOT)
set(BUILTINS_${target}_CMAKE_EXE_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "") set(BUILTINS_${target}_CMAKE_EXE_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "")
set(BUILTINS_${target}_CMAKE_SHARED_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "") set(BUILTINS_${target}_CMAKE_SHARED_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "")
set(BUILTINS_${target}_CMAKE_MODULE_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "") set(BUILTINS_${target}_CMAKE_MODULE_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "")
list(APPEND RUNTIME_TARGETS "${target}") list(APPEND RUNTIME_TARGETS "${target}")
set(RUNTIMES_${target}_CMAKE_SYSTEM_NAME Windows CACHE STRING "") set(RUNTIMES_${target}_CMAKE_SYSTEM_NAME Windows CACHE STRING "")
set(RUNTIMES_${target}_CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "") set(RUNTIMES_${target}_CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "")
set(RUNTIMES_${target}_LIBCXX_ABI_VERSION 2 CACHE STRING "") set(RUNTIMES_${target}_LIBCXX_ABI_VERSION 2 CACHE STRING "")
set(RUNTIMES_${target}_LIBCXX_ENABLE_FILESYSTEM OFF CACHE BOOL "")
set(RUNTIMES_${target}_LIBCXX_ENABLE_ABI_LINKER_SCRIPT OFF CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ENABLE_ABI_LINKER_SCRIPT OFF CACHE BOOL "")
set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "")
set(RUNTIMES_${target}_LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx" CACHE STRING "") set(RUNTIMES_${target}_LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx" CACHE STRING "")
set(RUNTIMES_${target}_CMAKE_C_FLAGS ${WINDOWS_COMPILER_FLAGS} CACHE STRING "") set(RUNTIMES_${target}_CMAKE_C_FLAGS ${WINDOWS_COMPILER_FLAGS} CACHE STRING "")
set(RUNTIMES_${target}_CMAKE_CXX_FLAGS ${WINDOWS_COMPILER_FLAGS} CACHE STRING "") set(RUNTIMES_${target}_CMAKE_CXX_FLAGS ${WINDOWS_COMPILER_FLAGS} CACHE STRING "")
set(RUNTIMES_${target}_CMAKE_EXE_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "") set(RUNTIMES_${target}_CMAKE_EXE_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "")
set(RUNTIMES_${target}_CMAKE_SHARED_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "") set(RUNTIMES_${target}_CMAKE_SHARED_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "")
set(RUNTIMES_${target}_CMAKE_MODULE_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "") set(RUNTIMES_${target}_CMAKE_MODULE_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "")
▲ Show 20 Lines • Show All 238 Lines • Show Last 20 Lines