This is an archive of the discontinued LLVM Phabricator instance.

Differential D153830

[mlir] Remove self-include from BytecodeOpInterface.h (NFC)
ClosedPublic

Authored by philass on Jun 26 2023, 7:13 PM.

Details

Reviewers
jpienaar
mehdi_amini
Commits
rGb287a4cbc40e: [mlir] Remove self-include from BytecodeOpInterface.h (NFC)

Diff Detail

Event Timeline

philass created this revision.Jun 26 2023, 7:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2023, 7:13 PM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 21 others. · View Herald Transcript
philass requested review of this revision.Jun 26 2023, 7:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2023, 7:13 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B241362: Diff 534818.Jun 26 2023, 7:56 PM
jpienaar accepted this revision.Jun 26 2023, 8:12 PM
This revision is now accepted and ready to land.Jun 26 2023, 8:12 PM
philass removed a reviewer: jpienaar.Jun 27 2023, 12:57 AM

@jpienaar thanks for the review!

Do you mind merging this for me. I don't have commit privileges.

This revision now requires review to proceed.Jun 27 2023, 12:57 AM
philass added a reviewer: jpienaar.Jun 27 2023, 2:40 PM

Ahh shucks. I don't know why my comment revoked the approval. Sorry about that

philass added a reviewer: mehdi_amini.Jun 29 2023, 2:03 PM
mehdi_amini retitled this revision from [mlir] Remove circular include from BytecodeOpInterface.h to [mlir] Remove self-include from BytecodeOpInterface.h (NFC).Jun 29 2023, 2:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 29 2023, 2:14 PM
Closed by commit rGb287a4cbc40e: [mlir] Remove self-include from BytecodeOpInterface.h (NFC) (authored by philass, committed by mehdi_amini). · Explain Why
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rGb287a4cbc40e: [mlir] Remove self-include from BytecodeOpInterface.h (NFC).

Revision Contents

PathSize
mlir/
include/
mlir/
Bytecode/
1 line

Diff 535997

mlir/include/mlir/Bytecode/BytecodeOpInterface.h

Show All 9 Lines
// `BytecodeOpInterface.td`. // `BytecodeOpInterface.td`.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef MLIR_BYTECODE_BYTECODEOPINTERFACE_H #ifndef MLIR_BYTECODE_BYTECODEOPINTERFACE_H
#define MLIR_BYTECODE_BYTECODEOPINTERFACE_H #define MLIR_BYTECODE_BYTECODEOPINTERFACE_H
#include "mlir/Bytecode/BytecodeImplementation.h" #include "mlir/Bytecode/BytecodeImplementation.h"
#include "mlir/Bytecode/BytecodeOpInterface.h"
#include "mlir/Bytecode/BytecodeReader.h" #include "mlir/Bytecode/BytecodeReader.h"
#include "mlir/Bytecode/BytecodeWriter.h" #include "mlir/Bytecode/BytecodeWriter.h"
#include "mlir/IR/OpDefinition.h" #include "mlir/IR/OpDefinition.h"
#include "mlir/Support/LogicalResult.h" #include "mlir/Support/LogicalResult.h"
/// Include the generated interface declarations. /// Include the generated interface declarations.
#include "mlir/Bytecode/BytecodeOpInterface.h.inc" #include "mlir/Bytecode/BytecodeOpInterface.h.inc"
#endif // MLIR_BYTECODE_BYTECODEOPINTERFACE_H #endif // MLIR_BYTECODE_BYTECODEOPINTERFACE_H