This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Refactor the selection of string's ABI in __config
ClosedPublic

Authored by ldionne on Jun 21 2023, 5:36 AM.

Details

Summary

This doesn't change the selection, but it expands the conditions to
add comments and make it clearer what's happening. It also removes a
-Wundef instance when we checked ARM_ARCH_7K >= 2 without checking
that it is defined in the first place.

Diff Detail

Event Timeline

ldionne created this revision.Jun 21 2023, 5:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2023, 5:36 AM
ldionne requested review of this revision.Jun 21 2023, 5:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2023, 5:36 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision.Jun 21 2023, 9:29 AM
Mordante added a subscriber: Mordante.

Thanks, this is quite more readable. LGTM!

This revision is now accepted and ready to land.Jun 21 2023, 9:29 AM