This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] vim integration: Mention python3 variant of bindings
ClosedPublic

Authored by jsilvanus on Jun 20 2023, 6:29 AM.

Details

Summary

The instructions in the documentation only mentioned how to include
bindings for clang-format into vim using python2. Add the instructions
for python3 which were already present in the source comments.

Diff Detail

Event Timeline

jsilvanus created this revision.Jun 20 2023, 6:29 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptJun 20 2023, 6:29 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
jsilvanus requested review of this revision.Jun 20 2023, 6:29 AM
NOTE: Clang-Format Team Automated Review Comment

It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes have a unit test (unless this is an NFC or refactoring, adding documentation etc..)

Add your unit tests in clang/unittests/Format and you can build with ninja FormatTests. We recommend using the verifyFormat(xxx) format of unit tests rather than EXPECT_EQ as this will ensure you change is tolerant to random whitespace changes (see FormatTest.cpp as an example)

For situations where your change is altering the TokenAnnotator.cpp which can happen if you are trying to improve the annotation phase to ensure we are correctly identifying the type of a token, please add a token annotator test in TokenAnnotatorTest.cpp

Don't change proposed key binding from K to I,
just add the python3 part.

This revision is now accepted and ready to land.Jun 21 2023, 7:57 AM