This is an archive of the discontinued LLVM Phabricator instance.

Differential D153317

[SelectionDAG] Remove isNullValue and isAllOnesValue
ClosedPublic

Authored by kazu on Jun 19 2023, 10:39 PM.

Details

Reviewers
MaskRay
dblaikie
Commits
rGe28bb6c3c797: [SelectionDAG] Remove isNullValue and isAllOnesValue
Summary

These functions have been deprecated since:

commit f271e5d9d44e833ef2264e5b0e9aa5f8383c173d
Author: Kazu Hirata <kazu@google.com>
Date:   Sun Mar 12 18:25:07 2023 -0700

Diff Detail

Unit TestsFailed

TimeTest
60,050 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

kazu created this revision.Jun 19 2023, 10:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2023, 10:39 PM
kazu requested review of this revision.Jun 19 2023, 10:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2023, 10:39 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
kazu added reviewers: MaskRay, dblaikie.Jun 19 2023, 10:39 PM
Harbormaster completed remote builds in B239919: Diff 532791.Jun 19 2023, 11:18 PM
dblaikie accepted this revision.Jun 20 2023, 1:16 PM

SGTM

This revision is now accepted and ready to land.Jun 20 2023, 1:16 PM
MaskRay accepted this revision.Jun 20 2023, 1:26 PM
This revision was landed with ongoing or failed builds.Jun 20 2023, 2:15 PM
Closed by commit rGe28bb6c3c797: [SelectionDAG] Remove isNullValue and isAllOnesValue (authored by kazu). · Explain Why
This revision was automatically updated to reflect the committed changes.
kazu added a commit: rGe28bb6c3c797: [SelectionDAG] Remove isNullValue and isAllOnesValue.

Revision Contents

PathSize
llvm/
include/
llvm/
CodeGen/
4 lines

Diff 532791

llvm/include/llvm/CodeGen/SelectionDAGNodes.h

Show First 20 Lines • Show All 1,609 Lines • ▼ Show 20 Linespublic:
uint64_t getLimitedValue(uint64_t Limit = UINT64_MAX) { uint64_t getLimitedValue(uint64_t Limit = UINT64_MAX) {
return Value->getLimitedValue(Limit); return Value->getLimitedValue(Limit);
} }
MaybeAlign getMaybeAlignValue() const { return Value->getMaybeAlignValue(); } MaybeAlign getMaybeAlignValue() const { return Value->getMaybeAlignValue(); }
Align getAlignValue() const { return Value->getAlignValue(); } Align getAlignValue() const { return Value->getAlignValue(); }
bool isOne() const { return Value->isOne(); } bool isOne() const { return Value->isOne(); }
bool isZero() const { return Value->isZero(); } bool isZero() const { return Value->isZero(); }
LLVM_DEPRECATED("use isZero instead", "isZero")
bool isNullValue() const { return isZero(); }
bool isAllOnes() const { return Value->isMinusOne(); } bool isAllOnes() const { return Value->isMinusOne(); }
LLVM_DEPRECATED("use isAllOnes instead", "isAllOnes")
bool isAllOnesValue() const { return isAllOnes(); }
bool isMaxSignedValue() const { return Value->isMaxValue(true); } bool isMaxSignedValue() const { return Value->isMaxValue(true); }
bool isMinSignedValue() const { return Value->isMinValue(true); } bool isMinSignedValue() const { return Value->isMinValue(true); }
bool isOpaque() const { return ConstantSDNodeBits.IsOpaque; } bool isOpaque() const { return ConstantSDNodeBits.IsOpaque; }
static bool classof(const SDNode *N) { static bool classof(const SDNode *N) {
return N->getOpcode() == ISD::Constant || return N->getOpcode() == ISD::Constant ||
N->getOpcode() == ISD::TargetConstant; N->getOpcode() == ISD::TargetConstant;
▲ Show 20 Lines • Show All 1,526 Lines • Show Last 20 Lines