This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] Add InsertNewlineAtEOF to .clang-format files
ClosedPublic

Authored by owenpan on Jun 17 2023, 3:41 PM.

Details

Diff Detail

Event Timeline

owenpan created this revision.Jun 17 2023, 3:41 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptJun 17 2023, 3:41 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
owenpan requested review of this revision.Jun 17 2023, 3:41 PM
owenpan updated this revision to Diff 532434.Jun 17 2023, 5:49 PM
owenpan edited the summary of this revision. (Show Details)

Took out Language: Cpp.

We also could add a clang-format style, the you wouldn't have to to touch all .clang-format files. ;)

This revision is now accepted and ready to land.Jun 18 2023, 12:01 PM

We also could add a clang-format style, the you wouldn't have to to touch all .clang-format files. ;)

Something like BasedOnStyle: clang-format? I like it but feel that it should be an undocumented feature. What do you all think?

We also could add a clang-format style, the you wouldn't have to to touch all .clang-format files. ;)

Something like BasedOnStyle: clang-format? I like it but feel that it should be an undocumented feature. What do you all think?

I don't know if I want this or if it just a joke. But if we do it, I would document it, something like. "Basically LLVM Style, which uses some of the newer options, to enforce some of the LLVM style guide rules."

We also could add a clang-format style, the you wouldn't have to to touch all .clang-format files. ;)

Something like BasedOnStyle: clang-format? I like it but feel that it should be an undocumented feature. What do you all think?

I don't know if I want this or if it just a joke. But if we do it, I would document it, something like. "Basically LLVM Style, which uses some of the newer options, to enforce some of the LLVM style guide rules."

That would seem odd with LLVM, Google, and other current BasedOnStyle values unless we make it hidden for "internal" use. I'll just land this patch as is and not worry about it now.

MyDeveloperDay accepted this revision.Jun 20 2023, 8:17 AM