[lldb] De-virtualize applicable functions in ValueObject (NFC)

[kastiglione]

Summary

Remove virtual from ValueObject functions that aren't overridden.

One such function, IsArrayItemForPointer, is not called and so is instead deleted.

[bulbazord]

Big fan of this kind of cleanup. Thanks!

lldb/include/lldb/Core/ValueObject.h

public:
   virtual ConstString GetTypeName() { return GetCompilerType().GetTypeName(); }
 
   virtual ConstString GetDisplayTypeName() { return GetTypeName(); }
 
   virtual ConstString GetQualifiedTypeName() {
     return GetCompilerType().GetTypeName();
   }
 
-  virtual lldb::LanguageType GetObjectRuntimeLanguage() {
+  lldb::LanguageType GetObjectRuntimeLanguage() {
     return GetCompilerType().GetMinimumLanguage();
   }
 
-  virtual uint32_t
+  uint32_t
   GetTypeInfo(CompilerType *pointee_or_element_compiler_type = nullptr) {
     return GetCompilerType().GetTypeInfo(pointee_or_element_compiler_type);
   }
 
-  virtual bool IsPointerType() { return GetCompilerType().IsPointerType(); }
+  bool IsPointerType() { return GetCompilerType().IsPointerType(); }
 
-  virtual bool IsArrayType() { return GetCompilerType().IsArrayType(); }
+  bool IsArrayType() { return GetCompilerType().IsArrayType(); }
 
-  virtual bool IsScalarType() { return GetCompilerType().IsScalarType(); }
+  bool IsScalarType() { return GetCompilerType().IsScalarType(); }
 
-  virtual bool IsPointerOrReferenceType() {
+  bool IsPointerOrReferenceType() {
     return GetCompilerType().IsPointerOrReferenceType();
   }
 
-  virtual bool IsPossibleDynamicType();
+  bool IsPossibleDynamicType();
 
   bool IsNilReference();
 
   bool IsUninitializedReference();
 
   virtual bool IsBaseClass() { return false; }
 
   bool IsBaseClass(uint32_t &depth);
public:
   virtual uint32_t GetBitfieldBitSize() { return 0; }
 
   virtual uint32_t GetBitfieldBitOffset() { return 0; }
 
   bool IsBitfield() {
     return (GetBitfieldBitSize() != 0) || (GetBitfieldBitOffset() != 0);
   }
 
-  virtual bool IsArrayItemForPointer() {
-    return m_flags.m_is_array_item_for_pointer;
-  }
-
   virtual const char *GetValueAsCString();
 
   virtual bool GetValueAsCString(const lldb_private::TypeFormatImpl &format,
                                  std::string &destination);
 
   bool GetValueAsCString(lldb::Format format, std::string &destination);
 
   virtual uint64_t GetValueAsUnsigned(uint64_t fail_value,
public:
   virtual lldb::ValueObjectSP CastPointerType(const char *name,
                                               CompilerType &ast_type);
 
   virtual lldb::ValueObjectSP CastPointerType(const char *name,
                                               lldb::TypeSP &type_sp);
 
   // The backing bits of this value object were updated, clear any descriptive
   // string, so we know we have to refetch them.
-  virtual void ValueUpdated() {
+  void ValueUpdated() {
     ClearUserVisibleData(eClearUserVisibleDataItemsValue |
                          eClearUserVisibleDataItemsSummary |
                          eClearUserVisibleDataItemsDescription);
   }
 
   virtual bool IsDynamic() { return false; }
 
   virtual bool DoesProvideSyntheticValue() { return false; }