This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Add missing dependency in llvm Support unittests
ClosedPublic

Authored by steven_wu on Jun 15 2023, 9:56 AM.

Details

Summary

Casting.cpp in llvm unittests includes "llvm/IR/User.h" which depends on
intrinsic_gen if using module because it needs to build IR module including
Attributes.h.

Diff Detail

Event Timeline

steven_wu created this revision.Jun 15 2023, 9:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2023, 9:56 AM
steven_wu requested review of this revision.Jun 15 2023, 9:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2023, 9:56 AM
dblaikie accepted this revision.Jun 15 2023, 1:05 PM

Could you include some details, if you can find them, about which commit introduced this dependency?

This revision is now accepted and ready to land.Jun 15 2023, 1:05 PM

Could you include some details, if you can find them, about which commit introduced this dependency?

I didn't check. I just want to do a quite test on SupportTests and realized it doesn't build anymore. I will do a quick search and make sure to put the context in the commit message.

Ah, this is a module specific issue. If you don't have module on, User.h will not pull in Attributes.h so it is fine without intrinsics_gen. Update commit message.

steven_wu edited the summary of this revision. (Show Details)Jun 15 2023, 4:34 PM
steven_wu added a reviewer: aprantl.

Ah, this is a module specific issue. If you don't have module on, User.h will not pull in Attributes.h so it is fine without intrinsics_gen. Update commit message.

Cool - thanks!

This revision was landed with ongoing or failed builds.Jun 16 2023, 9:47 AM
This revision was automatically updated to reflect the committed changes.