Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[scudo] Do not compile timing.cpp if LLVM_LIBC_INCLUDE_SCUDO=on
ClosedPublic

Authored by alfredfo on Jun 14 2023, 4:12 PM.

Details

Summary

Temporary hack until LLVM libc supports inttypes.h print format macros

timing.h uses the PRId64 macro which is not included in llvm libc yet

Bug: https://github.com/llvm/llvm-project/issues/63317

Diff Detail

Event Timeline

alfredfo created this revision.Jun 14 2023, 4:12 PM
alfredfo requested review of this revision.Jun 14 2023, 4:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2023, 4:12 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
thesamesam retitled this revision from [scudo] Do not compile timing.cpp if LLVM_LIBC_INCLUDE_SCUDO=on Temporary hack until LLVM libc supports inttypes.h print format macros See: https://github.com/llvm/llvm-project/issues/63317#issuecomment-1591906241 to [scudo] Do not compile timing.cpp if LLVM_LIBC_INCLUDE_SCUDO=on.Jun 14 2023, 4:17 PM
thesamesam edited the summary of this revision. (Show Details)
Chia-hungDuan accepted this revision.Jun 14 2023, 5:30 PM
This revision is now accepted and ready to land.Jun 14 2023, 5:30 PM
Chia-hungDuan requested changes to this revision.Jun 14 2023, 7:19 PM

Sorry, I forgot one thing, you may also want to exclude the unit test lib/scudo/standalone/tests/timing_test.cpp as well

This revision now requires changes to proceed.Jun 14 2023, 7:19 PM
alfredfo updated this revision to Diff 531752.Jun 15 2023, 7:43 AM

Skip timing_test.cpp if LLVM_LIBC_INCLUDE_SCUDO=on too

Chia-hungDuan accepted this revision.Jun 15 2023, 8:55 AM
This revision is now accepted and ready to land.Jun 15 2023, 8:55 AM
michaelrj accepted this revision.Jun 15 2023, 9:47 AM

LGTM, thank you for doing this!

thesamesam accepted this revision.Jun 15 2023, 4:08 PM